I noticed a potential issue from Scala inspections, like this clause in LiveEntity.scala around line 586:
The issue is that acc.metadata is Option[String], so can't equal Some[String]. This just meant to be:
This may or may not actually cause a bug, but seems worth fixing. And then there are a number of other ones like this, mostly in tests, that might likewise mask real assertion problems.
Many are, interestingly, flagging items like this on a Seq[String]:
It complains that Any => Any is compared to String. Either it's wrong, or somehow, this is parsed as (_.getFoo).equals("foo")). In any event, easy enough to write this more clearly as:
And so on.