[SPARK-22415] lint-r fails if lint-r.R installs any new packages

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Incomplete
• Affects Version/s: 2.3.0
• Component/s: Tests
• Labels: bulk-closed

Environment

OSX 10.12.6 R 3.4.2

• Assignee: Unassigned
• Reporter: Joel Croteau
• Created: 01/Nov/17 21:28
• Updated: 08/Oct/19 05:42
• Resolved: 08/Oct/19 05:42

Description

The dev/lint-r script checks for lint failures by seeing if anything is output to stdout by lint-r.R. Since package installations will often produce output to stdout, this will cause it to report a failure even if lint-r.R succeeded. This would also mean that if there were a failure further up in lint-r.R that output a message to stderr, it would not detect this and think lint-r.R had succeeded. It would be preferable for lint-r.R to output lints to stderr and for lint-r to check that and/or for lint-r.R to return a failure code if there are any lints, which lint-r could check for. I will write a patch to do this.