Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-22066

Update checkstyle to 8.2, enable it, fix violations

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.0
    • Fix Version/s: 2.3.0
    • Component/s: Build
    • Labels:
      None

      Description

      While working on Scala 2.12 changes, I noted we could update various build plugins to their latest version, such as the scala-maven-plugin.

      While doing that I noticed that the checkstyle plugin config had some bogus config, and that it was actually disabled and could be enabled now (build prints ERRORs but doesn't fail). This noise was making it a little hard to figure out what errors are real and new in the Scala 2.12 changes I'm working on, so should be fixed and stay fixed by being treated as errors.

      And then I noted we could update checkstyle itself to 8.2, and fix existing and additional style errors.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                srowen Sean Owen
                Reporter:
                srowen Sean Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: