Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-21875

Jenkins passes Java code that violates ./dev/lint-java

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.3.0
    • Component/s: Build
    • Labels:
      None

      Description

      Two recent PRs merged which caused lint-java errors:

      ========================================================================
      Running Java style checks
      ========================================================================
      Using `mvn` from path: /home/ubuntu/spark/build/apache-maven-3.5.0/bin/mvn
      Checkstyle checks failed at following occurrences:
      [ERROR] src/main/java/org/apache/spark/memory/TaskMemoryManager.java:[77] (sizes) LineLength: Line is longer than 100 characters (found 106).
      [ERROR] src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java:[1340] (sizes) LineLength: Line is longer than 100 characters (found 106).
      [error] running /home/ubuntu/spark/dev/lint-java ; received return code 1
      

      The first error is from https://github.com/apache/spark/pull/19025 and the second is from https://github.com/apache/spark/pull/18488

      Should we be expecting Jenkins to enforce Java code style pre-commit?

        Attachments

          Activity

            People

            • Assignee:
              aash Andrew Ash
              Reporter:
              aash Andrew Ash
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: