Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-21623

Comments of parentStats on ml/tree/impl/DTStatsAggregator.scala is wrong

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.3.0
    • Fix Version/s: 2.3.0
    • Component/s: ML
    • Labels:
      None

      Description

         * Note: this is necessary because stats for the parent node are not available
         *       on the first iteration of tree learning.
         */
        private val parentStats: Array[Double] = new Array[Double](statsSize)
      

      This comment is not right. Actually, parentStats is not only used for the first iteration. It is used with all the iteration for unordered featrues.

        Attachments

          Activity

            People

            • Assignee:
              peng.meng@intel.com Peng Meng
              Reporter:
              peng.meng@intel.com Peng Meng
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: