[SPARK-21188] releaseAllLocksForTask should synchronize the whole method

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.0, 2.2.0
• Fix Version/s: 2.3.0
• Component/s: Block Manager, Spark Core
• Assignee: Coyote Hills
• Reporter: Feng Liu
• Shepherd: Josh Rosen
• Created: 23/Jun/17 05:20
• Updated: 29/Jun/17 23:03
• Resolved: 29/Jun/17 23:03

Description

Since the objects readLocksByTask, writeLocksByTask and infos are coupled and supposed to be modified by other threads concurrently, all the read and writes of them in the releaseAllLocksForTask method should be protected by a single synchronized block. The fine-grained synchronization in the current code can cause some test flakiness.

Issue Links

• links to: [Github] Pull Request #18400 (liufengdb)