Details
-
Improvement
-
Status: Resolved
-
Trivial
-
Resolution: Fixed
-
2.1.0
-
None
Description
org.apache.spark.scheduler.FairSchedulableBuilder#addTaskSetManager contains the code snippet:
override def addTaskSetManager(manager: Schedulable, properties: Properties) { var poolName = DEFAULT_POOL_NAME var parentPool = rootPool.getSchedulableByName(poolName) if (properties != null) { poolName = properties.getProperty(FAIR_SCHEDULER_PROPERTIES, DEFAULT_POOL_NAME) parentPool = rootPool.getSchedulableByName(poolName) if (parentPool == null) {
parentPool = rootPool.getSchedulableByName(poolName) is called twice if properties != null.
I'm not sure whether this is an oversight or there's something else missing. This piece of the code hasn't been modified since 2013, so I doubt that this is a serious issue.
Attachments
Issue Links
- links to