[SPARK-20344] Duplicate call in FairSchedulableBuilder.addTaskSetManager

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.1.0
• Fix Version/s: 2.2.0
• Component/s: Scheduler, Spark Core
• Assignee: Robert Stupp
• Reporter: Robert Stupp
• Created: 15/Apr/17 07:23
• Updated: 17/May/20 17:47
• Resolved: 18/Apr/17 10:02

Description

org.apache.spark.scheduler.FairSchedulableBuilder#addTaskSetManager contains the code snippet:

  override def addTaskSetManager(manager: Schedulable, properties: Properties) {
    var poolName = DEFAULT_POOL_NAME
    var parentPool = rootPool.getSchedulableByName(poolName)
    if (properties != null) {
      poolName = properties.getProperty(FAIR_SCHEDULER_PROPERTIES, DEFAULT_POOL_NAME)
      parentPool = rootPool.getSchedulableByName(poolName)
      if (parentPool == null) {

parentPool = rootPool.getSchedulableByName(poolName) is called twice if properties != null.

I'm not sure whether this is an oversight or there's something else missing. This piece of the code hasn't been modified since 2013, so I doubt that this is a serious issue.

Issue Links

• links to: [Github] Pull Request #17647 (snazy)