[SPARK-20095] A code bug in CodegenContext.withSubExprEliminationExprs

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Incomplete
• Affects Version/s: 2.1.0
• Component/s: SQL
• Labels: bulk-closed
• Assignee: Unassigned
• Reporter: song fengfei
• Created: 25/Mar/17 09:02
• Updated: 21/May/19 04:15
• Resolved: 21/May/19 04:15

Description

In the function:CodegenContext.withSubExprEliminationExprs...{
val oldsubExprEliminationExprs = subExprEliminationExprs
subExprEliminationExprs.clear
...
// Restore previous subExprEliminationExprs
subExprEliminationExprs.clear
oldsubExprEliminationExprs.foreach(subExprEliminationExprs += _)
}
it seems that the oldsubExprEliminationExprs and subExprEliminationExprs are the same instance,after the second subExprEliminationExprs.clear ,the oldsubExprEliminationExprs is also cleared,so,the previous subExprEliminationExprs in CodegenContext will not be Restored.
Is it a bug?