[SPARK-17955] Use the same read path in DataFrameReader.jdbc and DataFrameReader.format("jdbc")

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 2.1.0
• Component/s: SQL
• Assignee: Hyukjin Kwon
• Reporter: Hyukjin Kwon
• Created: 15/Oct/16 12:34
• Updated: 12/Dec/22 17:50
• Resolved: 18/Oct/16 20:48

Description

It seems APIs in DataFrameReader/DataFrameWriter share format("...").load() or format("...").save() APIs for json(...)/csv(...) and etc.

We can share this within DataFrameReader.jdbc(...) too consistently with other APIs.

-    // connectionProperties should override settings in extraOptions.
-    val params = extraOptions.toMap ++ connectionProperties.asScala.toMap
-    val options = new JDBCOptions(url, table, params)
-    val relation = JDBCRelation(parts, options)(sparkSession)
-    sparkSession.baseRelationToDataFrame(relation)
+    // connectionProperties should override settings in extraOptions
+    this.extraOptions = this.extraOptions ++ (connectionProperties.asScala)
+    // explicit url and dbtable should override all
+    this.extraOptions += ("url" -> url, "dbtable" -> table)
+    format("jdbc").load()

Issue Links

• links to: [Github] Pull Request #15499 (HyukjinKwon)