Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-16489

Test harness to prevent expression code generation from reusing variable names

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.3, 2.0.0
    • Component/s: SQL
    • Labels:
      None
    • Target Version/s:

      Description

      In code generation, it is incorrect for expressions to reuse variable names across different instances of itself. As an example, SPARK-16488 reports a bug in which pmod expression reuses variable name "r".

      This patch updates ExpressionEvalHelper test harness to always project two instances of the same expression, which will help us catch variable reuse problems in expression unit tests.

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              rxin Reynold Xin
              Reporter:
              rxin Reynold Xin

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment