Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-13085

Add scalastyle command used in build testing

    XMLWordPrintableJSON

Details

    • Wish
    • Status: Resolved
    • Major
    • Resolution: Duplicate
    • None
    • None
    • Build, Tests
    • None

    Description

      As an occasional or new contributor, it is easy to screw up scala style. But looking at the output logs (for example https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50300/consoleFull ) it is not obvious how to fix the scala style tests, even when reading the scala style guide.

      ========================================================================
      Running Scala style checks
      ========================================================================
      Scalastyle checks failed at following occurrences:
      [error] /home/jenkins/workspace/SparkPullRequestBuilder/core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala:22:0: import.ordering.wrongOrderInGroup.message
      [error] (core/compile:scalastyle) errors exist
      [error] Total time: 9 s, completed Jan 28, 2016 2:11:00 PM
      [error] running /home/jenkins/workspace/SparkPullRequestBuilder/dev/lint-scala ; received return code 1
      

      This ask is that the command used to check scalastyle is presented in the log so a developer does not have to wait for the build process to check if a pull request should pass scala style checks.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              drcrallen Charles R Allen
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: