Uploaded image for project: 'Spark'
  1. Spark
  2. SPARK-12701

Logging FileAppender should use join to ensure thread is finished

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.1, 2.0.0
    • Component/s: Spark Core
    • Labels:
      None

      Description

      Currently, FileAppender for logging uses wait/notifyAll to signal that the writing thread has finished. While I was trying to write a regression test for a fix of SPARK-9844, the writing thread was not able to fully complete before the process was shutdown, despite calling FileAppender.awaitTermination. Using join ensures the thread completes and would simplify things a little more.

        Attachments

          Activity

            People

            • Assignee:
              bryanc Bryan Cutler
              Reporter:
              bryanc Bryan Cutler
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: