[SPARK-12701] Logging FileAppender should use join to ensure thread is finished

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6.1, 2.0.0
• Component/s: Spark Core
• Assignee: Bryan Cutler
• Reporter: Bryan Cutler
• Created: 08/Jan/16 00:00
• Updated: 15/Jan/16 21:20
• Resolved: 08/Jan/16 19:09

Description

Currently, FileAppender for logging uses wait/notifyAll to signal that the writing thread has finished. While I was trying to write a regression test for a fix of SPARK-9844, the writing thread was not able to fully complete before the process was shutdown, despite calling FileAppender.awaitTermination. Using join ensures the thread completes and would simplify things a little more.

Issue Links

• links to: [Github] Pull Request #10654 (BryanCutler)