[SPARK-12470] Incorrect calculation of row size in o.a.s.sql.catalyst.expressions.codegen.GenerateUnsafeRowJoiner

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.2
• Fix Version/s: 1.6.1, 2.0.0
• Component/s: SQL
• Assignee: Peter George Robbins
• Reporter: Peter George Robbins
• Created: 21/Dec/15 22:33
• Updated: 05/Jan/16 21:11
• Resolved: 04/Jan/16 18:47

Description

While looking into https://issues.apache.org/jira/browse/SPARK-12319 I noticed that the row size is incorrectly calculated.

The "sizeReduction" value is calculated in words:

// The number of words we can reduce when we concat two rows together.
// The only reduction comes from merging the bitset portion of the two rows, saving 1 word.
val sizeReduction = bitset1Words + bitset2Words - outputBitsetWords

but then it is subtracted from the size of the row in bytes:

out.pointTo(buf, ${schema1.size + schema2.size}, sizeInBytes - $sizeReduction);

Issue Links

• is related to: SPARK-12647 1.6 branch test failure o.a.s.sql.execution.ExchangeCoordinatorSuite.determining the number of reducers: aggregate operator
• links to: [Github] Pull Request #10421 (robbinspg)