[SPARK-11417] @Override is not supported by older version of Janino

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.1
• Fix Version/s: 1.5.2, 1.6.0
• Target Version/s: 1.5.2, 1.6.0
• Assignee: Davies Liu
• Reporter: Davies Liu
• Created: 30/Oct/15 05:14
• Updated: 30/Oct/15 07:38
• Resolved: 30/Oct/15 07:38

Description

java.util.concurrent.ExecutionException: java.lang.Exception: failed to compile: org.codehaus.commons.compiler.CompileException: Line 15, Column 9: Invalid character input "@" (character code 64)

public SpecificOrdering generate(org.apache.spark.sql.catalyst.expressions.Expression[] expr) {
  return new SpecificOrdering(expr);
}

class SpecificOrdering extends org.apache.spark.sql.catalyst.expressions.codegen.BaseOrdering {
  
  private org.apache.spark.sql.catalyst.expressions.Expression[] expressions;
  
  
  
  public SpecificOrdering(org.apache.spark.sql.catalyst.expressions.Expression[] expr) {
    expressions = expr;
    
  }
  
  @Override
  public int compare(InternalRow a, InternalRow b) {
    InternalRow i = null;  // Holds current row being evaluated.
    
    i = a;
    boolean isNullA2;
    long primitiveA3;
    {
      /* input[2, LongType] */
      
      boolean isNull0 = i.isNullAt(2);
      long primitive1 = isNull0 ? -1L : (i.getLong(2));
      
      isNullA2 = isNull0;
      primitiveA3 = primitive1;
    }
    i = b;
    boolean isNullB4;
    long primitiveB5;
    {
      /* input[2, LongType] */
      
      boolean isNull0 = i.isNullAt(2);
      long primitive1 = isNull0 ? -1L : (i.getLong(2));
      
      isNullB4 = isNull0;
      primitiveB5 = primitive1;
    }
    if (isNullA2 && isNullB4) {
      // Nothing
    } else if (isNullA2) {
      return 1;
    } else if (isNullB4) {
      return -1;
    } else {
      int comp = (primitiveA3 > primitiveB5 ? 1 : primitiveA3 < primitiveB5 ? -1 : 0);
      if (comp != 0) {
        return -comp;
      }
    }
    
    return 0;
  }
}

Issue Links

• links to: [Github] Pull Request #9372 (davies)