[SPARK-11163] Remove unnecessary addPendingTask calls in TaskSetManager.executorLost

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: Scheduler, Spark Core
• Target Version/s: 1.5.2, 1.6.0
• Assignee: Kay Ousterhout
• Reporter: Kay Ousterhout
• Created: 16/Oct/15 23:26
• Updated: 17/May/20 17:48
• Resolved: 22/Oct/15 18:39

Description

The proposed commit removes unnecessary calls to addPendingTask in
TaskSetManager.executorLost. These calls are unnecessary: for
tasks that are still pending and haven't been launched, they're
still in all of the correct pending lists, so calling addPendingTask
has no effect. For tasks that are currently running (which may still be
in the pending lists, depending on how they were scheduled), we call
addPendingTask in handleFailedTask, so the calls at the beginning
of executorLost are redundant.

I think these calls are left over from when we re-computed the locality
levels in addPendingTask; now that we call recomputeLocality separately,
I don't think these are necessary.

Issue Links

• links to: [Github] Pull Request #9154 (kayousterhout)