[SPARK-11078] Ensure spilling tests are actually spilling

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: Spark Core, Tests
• Target Version/s: 1.6.0
• Assignee: Andrew Or
• Reporter: Andrew Or
• Created: 13/Oct/15 06:51
• Updated: 24/Jun/16 20:51
• Resolved: 22/Oct/15 20:00

Description

The new unified memory management model in SPARK-10983 uncovered many brittle tests that rely on arbitrary thresholds to detect spilling. Some tests don't even assert that spilling did occur.

We should go through all the places where we test spilling behavior and correct the tests, a subset of which are definitely incorrect. Potential suspects:

• UnsafeShuffleSuite
• ExternalAppendOnlyMapSuite
• ExternalSorterSuite
• SQLQuerySuite
• DistributedSuite

Issue Links

• is related to: SPARK-16193 Address flaky ExternalAppendOnlyMapSuite spilling tests
• links to: [Github] Pull Request #9124 (andrewor14)