Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.5, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Followup task of SOLR-8396

      1. SOLR-9986.patch
        87 kB
        Cao Manh Dat
      2. SOLR-9986.patch
        87 kB
        Cao Manh Dat

        Issue Links

          Activity

          Hide
          caomanhdat Cao Manh Dat added a comment -

          Patch for this ticket.
          Tomás Fernández Löbbe Please take a look at the patch.

          Show
          caomanhdat Cao Manh Dat added a comment - Patch for this ticket. Tomás Fernández Löbbe Please take a look at the patch.
          Hide
          tomasflobbe Tomás Fernández Löbbe added a comment -

          Looks good.

          -    assertQ(req("q", "dateRemove:*", "indent", "true"), "//result[@numFound = '4']");
          +    if (!isPointField) {
          +      assertQ(req("q", "dateRemove:*", "indent", "true"), "//result[@numFound = '4']");
          +    }
          

          In other cases I modified the query to something like dateRemove:[* TO *] to avoid skipping it

          Show
          tomasflobbe Tomás Fernández Löbbe added a comment - Looks good. - assertQ(req( "q" , "dateRemove:*" , "indent" , " true " ), " //result[@numFound = '4']" ); + if (!isPointField) { + assertQ(req( "q" , "dateRemove:*" , "indent" , " true " ), " //result[@numFound = '4']" ); + } In other cases I modified the query to something like dateRemove:[* TO *] to avoid skipping it
          Hide
          caomanhdat Cao Manh Dat added a comment -

          Tomás Fernández Löbbe Good idea. Here are modified patch based on your hint.

          Show
          caomanhdat Cao Manh Dat added a comment - Tomás Fernández Löbbe Good idea. Here are modified patch based on your hint.
          Hide
          caomanhdat Cao Manh Dat added a comment -

          I will commit this patch shortly, is that ok Tomás Fernández Löbbe?

          Show
          caomanhdat Cao Manh Dat added a comment - I will commit this patch shortly, is that ok Tomás Fernández Löbbe ?
          Hide
          tomasflobbe Tomás Fernández Löbbe added a comment -

          LGTM. +1 to commit

          Show
          tomasflobbe Tomás Fernández Löbbe added a comment - LGTM. +1 to commit
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3131ec2d99401c1fd1fc33a00343a59a78ab6445 in lucene-solr's branch refs/heads/master from Cao Manh Dat
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3131ec2 ]

          SOLR-9986: Implement DatePointField

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3131ec2d99401c1fd1fc33a00343a59a78ab6445 in lucene-solr's branch refs/heads/master from Cao Manh Dat [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3131ec2 ] SOLR-9986 : Implement DatePointField
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4c2ed22b3721b7d6a86e5809821ca88f9af833ad in lucene-solr's branch refs/heads/branch_6x from Cao Manh Dat
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4c2ed22 ]

          SOLR-9986: Implement DatePointField

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4c2ed22b3721b7d6a86e5809821ca88f9af833ad in lucene-solr's branch refs/heads/branch_6x from Cao Manh Dat [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4c2ed22 ] SOLR-9986 : Implement DatePointField
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7af6cc97151d727cb4d4e8730491a32e56a29397 in lucene-solr's branch refs/heads/master from Cao Manh Dat
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7af6cc9 ]

          SOLR-9986: Fix precommit

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7af6cc97151d727cb4d4e8730491a32e56a29397 in lucene-solr's branch refs/heads/master from Cao Manh Dat [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7af6cc9 ] SOLR-9986 : Fix precommit
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8a996753920170ac1e6e8960d6b63848ccc1ea44 in lucene-solr's branch refs/heads/master from Tomas Fernandez Lobbe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8a99675 ]

          SOLR-9986: Add javadoc to DatePointField class

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8a996753920170ac1e6e8960d6b63848ccc1ea44 in lucene-solr's branch refs/heads/master from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8a99675 ] SOLR-9986 : Add javadoc to DatePointField class
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9382ddb3fa93c53c3a5c62abf465031e2f6c24e1 in lucene-solr's branch refs/heads/branch_6x from Tomas Fernandez Lobbe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9382ddb ]

          SOLR-9986: Add javadoc to DatePointField class

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9382ddb3fa93c53c3a5c62abf465031e2f6c24e1 in lucene-solr's branch refs/heads/branch_6x from Tomas Fernandez Lobbe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9382ddb ] SOLR-9986 : Add javadoc to DatePointField class
          Hide
          tomasflobbe Tomás Fernández Löbbe added a comment -

          Note that the last commit (8a99675 and 9382ddb) is only Javadoc and it didn't make it to version 6.5. Sorry if it caused any confusion.

          Show
          tomasflobbe Tomás Fernández Löbbe added a comment - Note that the last commit (8a99675 and 9382ddb) is only Javadoc and it didn't make it to version 6.5. Sorry if it caused any confusion.

            People

            • Assignee:
              caomanhdat Cao Manh Dat
              Reporter:
              tomasflobbe Tomás Fernández Löbbe
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development