[SOLR-9937] StandardDirectoryFactory::move never uses atomic implementation

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Assignee: Mark Miller
• Reporter: Mike Drob
• Created: 06/Jan/17 16:50
• Updated: 08/Jun/19 15:28
• Resolved: 09/Jan/17 23:16

Description

      Path path1 = ((FSDirectory) baseFromDir).getDirectory().toAbsolutePath();
      Path path2 = ((FSDirectory) baseFromDir).getDirectory().toAbsolutePath();
      
      try {
        Files.move(path1.resolve(fileName), path2.resolve(fileName), StandardCopyOption.ATOMIC_MOVE);
      } catch (AtomicMoveNotSupportedException e) {
        Files.move(path1.resolve(fileName), path2.resolve(fileName));
      }

Because path1 == path2 this code never does anything and move always defaults to the less efficient implementation in DirectoryFactory.

Issue Links

• duplicates: SOLR-9902 StandardDirectoryFactory should use Files API for it's move implementation.
• relates to: SOLR-9901 Implement move in HdfsDirectoryFactory.
• relates to: SOLR-9902 StandardDirectoryFactory should use Files API for it's move implementation.