Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9926

Allow passing arbitrary java system properties to zkcli

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.3
    • Fix Version/s: 6.5, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Currently zkcli does not allow passing arbitrary java system properties (e.g. java.io.tmpdir). It only supports configuring ZK ACLs via SOLR_ZK_CREDS_AND_ACLS environment variable. While we can overload SOLR_ZK_CREDS_AND_ACLS with additional parameters, it seems unclean. This jira is to add another environment variable to pass these parameters.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user hgadre opened a pull request:

          https://github.com/apache/lucene-solr/pull/134

          SOLR-9926 Add an environment variable to zkcli to pass java system properties

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/hgadre/lucene-solr SOLR-9926_fix

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/134.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #134


          commit a308ecf6a675dbd6e26f3b79ef26814bd1d02efe
          Author: Hrishikesh Gadre <hgadre@cloudera.com>
          Date: 2017-01-04T18:53:24Z

          SOLR-9926 Add an environment variable to zkcli to pass java system properties


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user hgadre opened a pull request: https://github.com/apache/lucene-solr/pull/134 SOLR-9926 Add an environment variable to zkcli to pass java system properties You can merge this pull request into a Git repository by running: $ git pull https://github.com/hgadre/lucene-solr SOLR-9926 _fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #134 commit a308ecf6a675dbd6e26f3b79ef26814bd1d02efe Author: Hrishikesh Gadre <hgadre@cloudera.com> Date: 2017-01-04T18:53:24Z SOLR-9926 Add an environment variable to zkcli to pass java system properties
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user hgadre commented on the issue:

          https://github.com/apache/lucene-solr/pull/134

          @markrmiller can you take a look?

          Show
          githubbot ASF GitHub Bot added a comment - Github user hgadre commented on the issue: https://github.com/apache/lucene-solr/pull/134 @markrmiller can you take a look?
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Looks good to me. I'll commit this tomorrow.

          Show
          markrmiller@gmail.com Mark Miller added a comment - Looks good to me. I'll commit this tomorrow.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9f58b6cd177f72b226c83adbb965cfe08d61d2fb in lucene-solr's branch refs/heads/master from markrmiller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9f58b6c ]

          SOLR-9926: Allow passing arbitrary java system properties to zkcli.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9f58b6cd177f72b226c83adbb965cfe08d61d2fb in lucene-solr's branch refs/heads/master from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9f58b6c ] SOLR-9926 : Allow passing arbitrary java system properties to zkcli.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 19cef2a021cc5fa1986697db15233dee717b265b in lucene-solr's branch refs/heads/branch_6x from markrmiller
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=19cef2a ]

          SOLR-9926: Allow passing arbitrary java system properties to zkcli.

          1. Conflicts:
          2. solr/CHANGES.txt
          Show
          jira-bot ASF subversion and git services added a comment - Commit 19cef2a021cc5fa1986697db15233dee717b265b in lucene-solr's branch refs/heads/branch_6x from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=19cef2a ] SOLR-9926 : Allow passing arbitrary java system properties to zkcli. Conflicts: solr/CHANGES.txt
          Hide
          markrmiller@gmail.com Mark Miller added a comment -

          Thanks Hrishikesh!

          Show
          markrmiller@gmail.com Mark Miller added a comment - Thanks Hrishikesh!

            People

            • Assignee:
              markrmiller@gmail.com Mark Miller
              Reporter:
              hgadre Hrishikesh Gadre
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development