Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9921

Separate SolrMetricProducer from SolrInfoMBean

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.4, 7.0
    • Fix Version/s: 6.4, 7.0
    • Component/s: metrics
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      SolrMetricProducer currently extends SolrInfoMBean but in most cases this is not needed, and then additional methods inherited from SolrInfoMBean don't make much sense. This issue is about separating these two interfaces.

        Activity

        Hide
        ab Andrzej Bialecki added a comment -

        Also, SolrMetricProducer.initializeMetrics currently returns Collection<String> with names of the registered metrics. This was originally intended as a way to ensure that at least some metrics were actually registered by a producer. However, in practice this is not that useful, and there are producers that can't know in advance what metrics they will register throughout the life-cycle of a component. For these reasons I'm planning to change this method so that it doesn't return anything.

        Show
        ab Andrzej Bialecki added a comment - Also, SolrMetricProducer.initializeMetrics currently returns Collection<String> with names of the registered metrics. This was originally intended as a way to ensure that at least some metrics were actually registered by a producer. However, in practice this is not that useful, and there are producers that can't know in advance what metrics they will register throughout the life-cycle of a component. For these reasons I'm planning to change this method so that it doesn't return anything.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 12d849221727d3294429397a456adebf583defbc in lucene-solr's branch refs/heads/master from Andrzej Bialecki
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=12d8492 ]

        SOLR-9921 Separate SolrMetricProducer from SolrInfoMBean.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 12d849221727d3294429397a456adebf583defbc in lucene-solr's branch refs/heads/master from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=12d8492 ] SOLR-9921 Separate SolrMetricProducer from SolrInfoMBean.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit be5cdc2d3c1092bf7068a9b608b190a6bafc7bcf in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=be5cdc2 ]

        SOLR-9921 Separate SolrMetricProducer from SolrInfoMBean.

        Show
        jira-bot ASF subversion and git services added a comment - Commit be5cdc2d3c1092bf7068a9b608b190a6bafc7bcf in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=be5cdc2 ] SOLR-9921 Separate SolrMetricProducer from SolrInfoMBean.

          People

          • Assignee:
            ab Andrzej Bialecki
            Reporter:
            ab Andrzej Bialecki
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development