[SOLR-9906] Use better check to validate if node recovered via PeerSync or Replication

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 6.4
• Assignee: Noble Paul
• Reporter: Pushkar Raste
• Created: 29/Dec/16 18:18
• Updated: 13/Apr/20 02:48
• Resolved: 09/Jan/17 17:39

Description

Tests LeaderFailureAfterFreshStartTest and PeerSyncReplicationTest currently rely on number of requests made to the leader's replication handler to check if node recovered via PeerSync or replication. This check is not very reliable and we have seen failures in the past.

While tinkering with different way to write a better test I found SOLR-9859. Now that SOLR-9859 is fixed, here is idea for better way to distinguish recovery via PeerSync vs Replication.

• For PeerSyncReplicationTest, if node successfully recovers via PeerSync, then file replication.properties should not exist

For LeaderFailureAfterFreshStartTest, if the freshly replicated node does not go into replication recovery after the leader failure, contents replication.properties should not change