Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9906

Use better check to validate if node recovered via PeerSync or Replication

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4
    • Component/s: None
    • Labels:
      None

      Description

      Tests LeaderFailureAfterFreshStartTest and PeerSyncReplicationTest currently rely on number of requests made to the leader's replication handler to check if node recovered via PeerSync or replication. This check is not very reliable and we have seen failures in the past.

      While tinkering with different way to write a better test I found SOLR-9859. Now that SOLR-9859 is fixed, here is idea for better way to distinguish recovery via PeerSync vs Replication.

      • For PeerSyncReplicationTest, if node successfully recovers via PeerSync, then file replication.properties should not exist

      For LeaderFailureAfterFreshStartTest, if the freshly replicated node does not go into replication recovery after the leader failure, contents replication.properties should not change

        Attachments

        1. SOLR-9906.patch
          15 kB
          Noble Paul
        2. SOLR-9906.patch
          10 kB
          Pushkar Raste
        3. SOLR-PeerSyncVsReplicationTest.diff
          8 kB
          Pushkar Raste

          Activity

            People

            • Assignee:
              noble.paul Noble Paul
              Reporter:
              praste Pushkar Raste
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: