Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9897

Solr UnifiedHighlighter should support hl.requireFieldMatch=false

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4
    • Component/s: highlighter
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Lucene's UnifiedHighlighter recently gained the ability for it to support Solr's hl.requireFieldMatch option. – LUCENE-7575 "fieldMatcher" option. We can finally enable support for this flag in Solr. Though I don't intend to add support for a regexp or glob at this time.

      1. SOLR-9897.patch
        6 kB
        David Smiley

        Activity

        Hide
        dsmiley David Smiley added a comment -

        I noticed UnifiedSolrHighlighter.java is indented 4-space instead of 2. I will fix that immediately right now before supplying a patch for the real issue.

        Show
        dsmiley David Smiley added a comment - I noticed UnifiedSolrHighlighter.java is indented 4-space instead of 2. I will fix that immediately right now before supplying a patch for the real issue.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9bd152804da4c7704b7d3ddd311485b524ec0166 in lucene-solr's branch refs/heads/master from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9bd1528 ]

        SOLR-9897: re-indent UnifiedSolrHighlighter.java

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9bd152804da4c7704b7d3ddd311485b524ec0166 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9bd1528 ] SOLR-9897 : re-indent UnifiedSolrHighlighter.java
        Hide
        dsmiley David Smiley added a comment -

        Here's a patch; pretty simple. I'll commit this tomorrow.

        Show
        dsmiley David Smiley added a comment - Here's a patch; pretty simple. I'll commit this tomorrow.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 20362deb7e6814c1922163595e7edeb652d3ce37 in lucene-solr's branch refs/heads/master from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=20362de ]

        SOLR-9897: Add hl.requireFieldMatch=false support when using the UnifiedHighlighter

        Show
        jira-bot ASF subversion and git services added a comment - Commit 20362deb7e6814c1922163595e7edeb652d3ce37 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=20362de ] SOLR-9897 : Add hl.requireFieldMatch=false support when using the UnifiedHighlighter
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 529c60d914a6c511813445d97d748ca3b4692fb5 in lucene-solr's branch refs/heads/branch_6x from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=529c60d ]

        SOLR-9897: Add hl.requireFieldMatch=false support when using the UnifiedHighlighter

        (cherry picked from commit 20362de)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 529c60d914a6c511813445d97d748ca3b4692fb5 in lucene-solr's branch refs/heads/branch_6x from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=529c60d ] SOLR-9897 : Add hl.requireFieldMatch=false support when using the UnifiedHighlighter (cherry picked from commit 20362de)

          People

          • Assignee:
            dsmiley David Smiley
            Reporter:
            dsmiley David Smiley
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development