Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9896

Instrument and collect metrics from thread pools

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: metrics
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      The metrics-core library has a InstrumentedExecutorService which collects stats on submitted, running, completed tasks and durations. This issue will expose such stats for all important thread pools in solr.

      1. SOLR-9896.patch
        10 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Patch which instruments the following thread pools:

        1. UpdateShardHandler's updateExecutor and recoveryExecutor at the path solr.http/updateShardHandler.threadPool.updateExecutor and solr.http/updateShardHandler.threadPool.recoveryExecutor
        2. HttpShardHandler's httpShardExecutor at solr.http/httpShardHandler.threadPool.httpShardExecutor
        3. CoreAdminHandler's parallelCoreAdminExecutor at solr.node/QUERYHANDLER./admin/cores.threadPool.parallelCoreAdminExecutor
        4. CoreContainer's coreContainerWorkExecutor and coreLoadExecutor at solr.node/threadPool.coreContainerWorkExecutor and solr.node/coreLoadExecutor

        There are still other thread pools in IndexFetcher and CDCR components which aren't instrumented but this is a good start. We can add instrumentation if people find them interesting.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Patch which instruments the following thread pools: UpdateShardHandler's updateExecutor and recoveryExecutor at the path solr.http/updateShardHandler.threadPool.updateExecutor and solr.http/updateShardHandler.threadPool.recoveryExecutor HttpShardHandler's httpShardExecutor at solr.http/httpShardHandler.threadPool.httpShardExecutor CoreAdminHandler's parallelCoreAdminExecutor at solr.node/QUERYHANDLER./admin/cores.threadPool.parallelCoreAdminExecutor CoreContainer's coreContainerWorkExecutor and coreLoadExecutor at solr.node/threadPool.coreContainerWorkExecutor and solr.node/coreLoadExecutor There are still other thread pools in IndexFetcher and CDCR components which aren't instrumented but this is a good start. We can add instrumentation if people find them interesting.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3c963967242aed73a906b7bc17c26a4b8b07083c in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3c96396 ]

        SOLR-9896: Instrument and collect metrics from query, update, core admin and core load thread pools

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3c963967242aed73a906b7bc17c26a4b8b07083c in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3c96396 ] SOLR-9896 : Instrument and collect metrics from query, update, core admin and core load thread pools
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 084f7a0604da846c3ccc2c45d560d93403c883e5 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=084f7a0 ]

        SOLR-9896: Instrument and collect metrics from query, update, core admin and core load thread pools

        (cherry picked from commit 3c963967242aed73a906b7bc17c26a4b8b07083c)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 084f7a0604da846c3ccc2c45d560d93403c883e5 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=084f7a0 ] SOLR-9896 : Instrument and collect metrics from query, update, core admin and core load thread pools (cherry picked from commit 3c963967242aed73a906b7bc17c26a4b8b07083c)

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            shalinmangar Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development