[SOLR-9873] Function result is compared with itself

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.3
• Fix Version/s: 6.4, 7.0
• Assignee: Yonik Seeley
• Reporter: AppChecker
• Created: 16/Dec/16 17:43
• Updated: 08/Jun/19 15:34
• Resolved: 16/Dec/16 23:42

Description

Hi!

In the method SolrTestCaseJ4.compareSolrDocument

SolrTestCaseJ4.java

    if(solrDocument1.getFieldNames().size() != solrDocument1.getFieldNames().size()) {
      return false;
    }

"solrDocument1.getFieldNames().size()" compare with itself

Probably, is should be:

SolrTestCaseJ4.java

    if(solrDocument1.getFieldNames().size() != solrDocument2.getFieldNames().size()) {
      return false;
    }

This possible defect found by static code analyzer AppChecker