[SOLR-9859] replication.properties cannot be updated after being written and neither replication.properties or index.properties are durable in the face of a crash

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.5.3, 6.3
• Fix Version/s: 6.4, 7.0
• Assignee: Mark Miller
• Reporter: Pushkar Raste
• Created: 12/Dec/16 19:51
• Updated: 08/Jun/19 15:31
• Resolved: 08/Jan/17 14:31

Description

If a shard recovers via replication (vs PeerSync) a file named replication.properties gets created. If the same shard recovers once more via replication, IndexFetcher fails to write latest replication information as it tries to create replication.properties but as file already exists. Here is the stack trace I saw

java.nio.file.FileAlreadyExistsException: <solr_home>\shard-3-001\cores\collection1\data\replication.properties
	at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)
	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)
	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)
	at sun.nio.fs.WindowsFileSystemProvider.newByteChannel(Unknown Source)
	at java.nio.file.spi.FileSystemProvider.newOutputStream(Unknown Source)
	at java.nio.file.Files.newOutputStream(Unknown Source)
	at org.apache.lucene.store.FSDirectory$FSIndexOutput.<init>(FSDirectory.java:413)
	at org.apache.lucene.store.FSDirectory$FSIndexOutput.<init>(FSDirectory.java:409)
	at org.apache.lucene.store.FSDirectory.createOutput(FSDirectory.java:253)
	at org.apache.solr.handler.IndexFetcher.logReplicationTimeAndConfFiles(IndexFetcher.java:689)
	at org.apache.solr.handler.IndexFetcher.fetchLatestIndex(IndexFetcher.java:501)
	at org.apache.solr.handler.IndexFetcher.fetchLatestIndex(IndexFetcher.java:265)
	at org.apache.solr.handler.ReplicationHandler.doFetch(ReplicationHandler.java:397)
	at org.apache.solr.cloud.RecoveryStrategy.replicate(RecoveryStrategy.java:157)
	at org.apache.solr.cloud.RecoveryStrategy.doRecovery(RecoveryStrategy.java:409)
	at org.apache.solr.cloud.RecoveryStrategy.run(RecoveryStrategy.java:222)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$0(ExecutorUtil.java:229)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)

Issue Links

• is duplicated by: SOLR-9580 Exception while updating statistics
• is duplicated by: SOLR-9951 FileAlreadyExistsException on replication.properties