Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9834

A variety of spots in the code can create a collection zk node after the collection has been removed.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      The results of this have annoyed me for some time. We should fail rather than create the collection node and only ensure the rest of the path exists if the collection node did not need to be created.

      Currently, leader elections can trigger on delete and recreate a collection zk node that was just removed. I think there was a bit of defense put in against that, but I still see it and this is more thorough as well as a step towards the ZK=Truth path.

      1. SOLR-9834.patch
        38 kB
        Mark Miller
      2. SOLR-9834.patch
        37 kB
        Mark Miller

        Activity

        Hide
        markrmiller@gmail.com Mark Miller added a comment - - edited

        Just needs some testing. We start doing our best to contain what/where can create a /collections/(collection) zk node.

        Show
        markrmiller@gmail.com Mark Miller added a comment - - edited Just needs some testing. We start doing our best to contain what/where can create a /collections/(collection) zk node.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        I'll commit this soon.

        Show
        markrmiller@gmail.com Mark Miller added a comment - I'll commit this soon.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1055209940faec71bd8046af3323d5982529525b in lucene-solr's branch refs/heads/master from markrmiller
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1055209 ]

        SOLR-9834: A variety of spots in the code can create a collection zk node after the collection has been removed.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1055209940faec71bd8046af3323d5982529525b in lucene-solr's branch refs/heads/master from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1055209 ] SOLR-9834 : A variety of spots in the code can create a collection zk node after the collection has been removed.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 89327187439ca2dfa2d49b5ae2bf327031e6d730 in lucene-solr's branch refs/heads/branch_6x from markrmiller
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8932718 ]

        SOLR-9834: A variety of spots in the code can create a collection zk node after the collection has been removed.

        1. Conflicts:
        2. solr/CHANGES.txt
        Show
        jira-bot ASF subversion and git services added a comment - Commit 89327187439ca2dfa2d49b5ae2bf327031e6d730 in lucene-solr's branch refs/heads/branch_6x from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8932718 ] SOLR-9834 : A variety of spots in the code can create a collection zk node after the collection has been removed. Conflicts: solr/CHANGES.txt

          People

          • Assignee:
            markrmiller@gmail.com Mark Miller
            Reporter:
            markrmiller@gmail.com Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development