Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: metrics
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      We added a bare bones metrics API in SOLR-9788 but due to limitations with the metrics servlet supplied by the metrics library, it can show statistics from only one metric registry. SOLR-4735 has added a hierarchy of metric registries and the /admin/metrics API should support showing all of them as well as be able to filter metrics from a given registry name.

      In this issue we will implement the improved /admin/metrics API.

      1. SOLR-9812.patch
        38 kB
        Shalin Shekhar Mangar
      2. SOLR-9812.patch
        30 kB
        Shalin Shekhar Mangar

        Activity

        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Patch which adds a new MetricsHandler

        The /admin/metrics API supports the following parameters:

        1. group=all,jvm,jetty,node,core – multiple group parameters can be specified and it also accepts comma-separated values. (default is 'all')
        2. type=all,counter,gauge,histogram,meter,timer – similar to the 'group' parameter, both multiple 'type' parameters as well as comma-separated values can be specified
        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Patch which adds a new MetricsHandler The /admin/metrics API supports the following parameters: group=all,jvm,jetty,node,core – multiple group parameters can be specified and it also accepts comma-separated values. (default is 'all') type=all,counter,gauge,histogram,meter,timer – similar to the 'group' parameter, both multiple 'type' parameters as well as comma-separated values can be specified
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Patch passes precommit and all tests.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Patch passes precommit and all tests.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit aa9b02bb16afe2af8c2437ffab46f4a09bda684e in lucene-solr's branch refs/heads/feature/metrics from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=aa9b02b ]

        SOLR-9812: Added a new /admin/metrics API to return all metrics collected by Solr via API

        Show
        jira-bot ASF subversion and git services added a comment - Commit aa9b02bb16afe2af8c2437ffab46f4a09bda684e in lucene-solr's branch refs/heads/feature/metrics from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=aa9b02b ] SOLR-9812 : Added a new /admin/metrics API to return all metrics collected by Solr via API
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5a17c1b5c56195eebc45c19452a4ec92e5d742fb in lucene-solr's branch refs/heads/feature/metrics from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5a17c1b ]

        SOLR-9812: Added entry to CHANGES.txt

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5a17c1b5c56195eebc45c19452a4ec92e5d742fb in lucene-solr's branch refs/heads/feature/metrics from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5a17c1b ] SOLR-9812 : Added entry to CHANGES.txt
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8bbdb6248c5de3f3bd61501ba42a50aeec29c78b in lucene-solr's branch refs/heads/master from Andrzej Bialecki
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8bbdb62 ]

        Squashed commit of branch 'feature/metrics', containing:
        SOLR-4735: Improve Solr metrics reporting
        SOLR-9812: Implement /admin/metrics API
        SOLR-9805: Use metrics-jvm library to instrument jvm internals
        SOLR-9788: Use instrumented jetty classes

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8bbdb6248c5de3f3bd61501ba42a50aeec29c78b in lucene-solr's branch refs/heads/master from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8bbdb62 ] Squashed commit of branch 'feature/metrics', containing: SOLR-4735 : Improve Solr metrics reporting SOLR-9812 : Implement /admin/metrics API SOLR-9805 : Use metrics-jvm library to instrument jvm internals SOLR-9788 : Use instrumented jetty classes
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9dde8a30303de4bce5da45189219dd6150252b29 in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9dde8a3 ]

        Cumulative patch from master, originally developed on branch
        'feature/metrics', which brings the following issues:

        • SOLR-4735: Improve Solr metrics reporting
        • SOLR-9812: Implement /admin/metrics API
        • SOLR-9805: Use metrics-jvm library to instrument jvm internals
        • SOLR-9788: Use instrumented jetty classes
        Show
        jira-bot ASF subversion and git services added a comment - Commit 9dde8a30303de4bce5da45189219dd6150252b29 in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9dde8a3 ] Cumulative patch from master, originally developed on branch 'feature/metrics', which brings the following issues: SOLR-4735 : Improve Solr metrics reporting SOLR-9812 : Implement /admin/metrics API SOLR-9805 : Use metrics-jvm library to instrument jvm internals SOLR-9788 : Use instrumented jetty classes

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            shalinmangar Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 168h
              168h
              Remaining:
              Remaining Estimate - 168h
              168h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development