[SOLR-9800] FacetComponent - move construction of SimpleFacets to a protected method

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 6.5, 7.0
• Assignee: Christine Poerschke
• Reporter: Jonny Marks
• Created: 24/Nov/16 18:17
• Updated: 08/Jun/19 15:28
• Resolved: 06/Feb/17 15:59

Description

This patch moves the construction of SimpleFacets from inside process() to a new protected method, allowing contrib modules to reuse FacetComponent with a different SimpleFacets implementation.

For example:

class MyFacetComponent extends FacetComponent {
  @Override
  protected SimpleFacets newSimpleFacets(SolrQueryRequest req, DocSet docSet, SolrParams params, ResponseBuilder rb) {
    return new SimpleFacets(req, docSet, params, rb) {
      @Override
      protected Predicate<BytesRef> newBytesRefFilter(String field, SolrParams params) {
        ...
        return new MyBytesRefFilter (...);
      }    
    };
  }
}

Issue Links

• relates to: SOLR-9912 SimpleFacets - support facet.excludeTerms parameter