Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: metrics
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Dropwizard metrics library integrated in SOLR-8785 provides a set of instrumented equivalents of Jetty classes. This allows us to collect statistics on Jetty's connector, thread pool and handlers.

      1. SOLR_9788.patch
        11 kB
        Shalin Shekhar Mangar
      2. SOLR_9788.patch
        11 kB
        Shalin Shekhar Mangar
      3. SOLR_9788.patch
        7 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          This patch:

          1. Adds metric-jetty9 as a dependency to the jetty server.
          2. Uses InstrumentedQueuedThreadPool and InstrumentedHandler in jetty configurations with a MetricRegistry named "solrjetty" obtained from SharedMetricRegistries.

          This is still work in progress.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - This patch: Adds metric-jetty9 as a dependency to the jetty server. Uses InstrumentedQueuedThreadPool and InstrumentedHandler in jetty configurations with a MetricRegistry named "solrjetty" obtained from SharedMetricRegistries. This is still work in progress.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Changes:

          • The metric registery is renamed to "solr" from "solrjetty"
          • Adds the MetricsServlet to /admin/metrics path – this lists all the jetty metrics that we are tracking
          • A new SolrMetricsServletContextListener that sets the "solr" MetricRegistry as a context attribute that is needed for MetricsServlet to work
          • The metrics library and its dependencies are now in the server module instead of core otherwise the metric registry looked up by SolrMetricsServletContextListener is different (due to them being loaded by different class loaders)

          Now that we have this in place, we can easily hook in the jvm metrics as well but I won't do that in this issue.

          As long as all metrics are registered with the same metric registry, the /admin/metrics path can display all of our metrics. This will likely not play well with the changes in SOLR-4735 because that creates a MetricRegistry for each core. We might need to write our own version of MetricsServlet or write a wrapper.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Changes: The metric registery is renamed to "solr" from "solrjetty" Adds the MetricsServlet to /admin/metrics path – this lists all the jetty metrics that we are tracking A new SolrMetricsServletContextListener that sets the "solr" MetricRegistry as a context attribute that is needed for MetricsServlet to work The metrics library and its dependencies are now in the server module instead of core otherwise the metric registry looked up by SolrMetricsServletContextListener is different (due to them being loaded by different class loaders) Now that we have this in place, we can easily hook in the jvm metrics as well but I won't do that in this issue. As long as all metrics are registered with the same metric registry, the /admin/metrics path can display all of our metrics. This will likely not play well with the changes in SOLR-4735 because that creates a MetricRegistry for each core. We might need to write our own version of MetricsServlet or write a wrapper.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Here's an example output from /admin/metrics:

          {
            "version" : "3.0.0",
            "gauges" : {
              "org.eclipse.jetty.server.handler.DefaultHandler.percent-4xx-15m" : {
                "value" : 0.0
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.percent-4xx-1m" : {
                "value" : 0.0
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.percent-4xx-5m" : {
                "value" : 0.0
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.percent-5xx-15m" : {
                "value" : 0.0
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.percent-5xx-1m" : {
                "value" : 0.0
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.percent-5xx-5m" : {
                "value" : 0.0
              },
              "org.eclipse.jetty.util.thread.QueuedThreadPool.qtp707806938.jobs" : {
                "value" : 0
              },
              "org.eclipse.jetty.util.thread.QueuedThreadPool.qtp707806938.size" : {
                "value" : 10
              },
              "org.eclipse.jetty.util.thread.QueuedThreadPool.qtp707806938.utilization" : {
                "value" : 0.6
              },
              "org.eclipse.jetty.util.thread.QueuedThreadPool.qtp707806938.utilization-max" : {
                "value" : 6.0E-4
              }
            },
            "counters" : {
              "org.eclipse.jetty.server.handler.DefaultHandler.active-dispatches" : {
                "count" : 0
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.active-requests" : {
                "count" : 0
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.active-suspended" : {
                "count" : 0
              }
            },
            "histograms" : { },
            "meters" : {
              "org.eclipse.jetty.server.handler.DefaultHandler.1xx-responses" : {
                "count" : 0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "units" : "events/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.2xx-responses" : {
                "count" : 6,
                "m15_rate" : 1.2,
                "m1_rate" : 1.2,
                "m5_rate" : 1.2,
                "mean_rate" : 0.8643507760595339,
                "units" : "events/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.3xx-responses" : {
                "count" : 0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "units" : "events/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.4xx-responses" : {
                "count" : 0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "units" : "events/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.5xx-responses" : {
                "count" : 0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "units" : "events/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.async-dispatches" : {
                "count" : 0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "units" : "events/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.async-timeouts" : {
                "count" : 0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "units" : "events/second"
              }
            },
            "timers" : {
              "org.eclipse.jetty.server.handler.DefaultHandler.connect-requests" : {
                "count" : 0,
                "max" : 0.0,
                "mean" : 0.0,
                "min" : 0.0,
                "p50" : 0.0,
                "p75" : 0.0,
                "p95" : 0.0,
                "p98" : 0.0,
                "p99" : 0.0,
                "p999" : 0.0,
                "stddev" : 0.0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.delete-requests" : {
                "count" : 0,
                "max" : 0.0,
                "mean" : 0.0,
                "min" : 0.0,
                "p50" : 0.0,
                "p75" : 0.0,
                "p95" : 0.0,
                "p98" : 0.0,
                "p99" : 0.0,
                "p999" : 0.0,
                "stddev" : 0.0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.dispatches" : {
                "count" : 6,
                "max" : 1.05,
                "mean" : 0.1916620195600857,
                "min" : 0.002,
                "p50" : 0.01,
                "p75" : 0.062000000000000006,
                "p95" : 1.05,
                "p98" : 1.05,
                "p99" : 1.05,
                "p999" : 1.05,
                "stddev" : 0.3872921205929878,
                "m15_rate" : 1.2,
                "m1_rate" : 1.2,
                "m5_rate" : 1.2,
                "mean_rate" : 0.8639066608151542,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.get-requests" : {
                "count" : 6,
                "max" : 1.05,
                "mean" : 0.1916620195600857,
                "min" : 0.002,
                "p50" : 0.01,
                "p75" : 0.062000000000000006,
                "p95" : 1.05,
                "p98" : 1.05,
                "p99" : 1.05,
                "p999" : 1.05,
                "stddev" : 0.3872921205929878,
                "m15_rate" : 1.2,
                "m1_rate" : 1.2,
                "m5_rate" : 1.2,
                "mean_rate" : 0.8639236767111607,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.head-requests" : {
                "count" : 0,
                "max" : 0.0,
                "mean" : 0.0,
                "min" : 0.0,
                "p50" : 0.0,
                "p75" : 0.0,
                "p95" : 0.0,
                "p98" : 0.0,
                "p99" : 0.0,
                "p999" : 0.0,
                "stddev" : 0.0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.move-requests" : {
                "count" : 0,
                "max" : 0.0,
                "mean" : 0.0,
                "min" : 0.0,
                "p50" : 0.0,
                "p75" : 0.0,
                "p95" : 0.0,
                "p98" : 0.0,
                "p99" : 0.0,
                "p999" : 0.0,
                "stddev" : 0.0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.options-requests" : {
                "count" : 0,
                "max" : 0.0,
                "mean" : 0.0,
                "min" : 0.0,
                "p50" : 0.0,
                "p75" : 0.0,
                "p95" : 0.0,
                "p98" : 0.0,
                "p99" : 0.0,
                "p999" : 0.0,
                "stddev" : 0.0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.other-requests" : {
                "count" : 0,
                "max" : 0.0,
                "mean" : 0.0,
                "min" : 0.0,
                "p50" : 0.0,
                "p75" : 0.0,
                "p95" : 0.0,
                "p98" : 0.0,
                "p99" : 0.0,
                "p999" : 0.0,
                "stddev" : 0.0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.post-requests" : {
                "count" : 0,
                "max" : 0.0,
                "mean" : 0.0,
                "min" : 0.0,
                "p50" : 0.0,
                "p75" : 0.0,
                "p95" : 0.0,
                "p98" : 0.0,
                "p99" : 0.0,
                "p999" : 0.0,
                "stddev" : 0.0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.put-requests" : {
                "count" : 0,
                "max" : 0.0,
                "mean" : 0.0,
                "min" : 0.0,
                "p50" : 0.0,
                "p75" : 0.0,
                "p95" : 0.0,
                "p98" : 0.0,
                "p99" : 0.0,
                "p999" : 0.0,
                "stddev" : 0.0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.requests" : {
                "count" : 6,
                "max" : 1.05,
                "mean" : 0.1916620195600857,
                "min" : 0.002,
                "p50" : 0.01,
                "p75" : 0.062000000000000006,
                "p95" : 1.05,
                "p98" : 1.05,
                "p99" : 1.05,
                "p999" : 1.05,
                "stddev" : 0.3872921205929878,
                "m15_rate" : 1.2,
                "m1_rate" : 1.2,
                "m5_rate" : 1.2,
                "mean_rate" : 0.86372875919477,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              },
              "org.eclipse.jetty.server.handler.DefaultHandler.trace-requests" : {
                "count" : 0,
                "max" : 0.0,
                "mean" : 0.0,
                "min" : 0.0,
                "p50" : 0.0,
                "p75" : 0.0,
                "p95" : 0.0,
                "p98" : 0.0,
                "p99" : 0.0,
                "p999" : 0.0,
                "stddev" : 0.0,
                "m15_rate" : 0.0,
                "m1_rate" : 0.0,
                "m5_rate" : 0.0,
                "mean_rate" : 0.0,
                "duration_units" : "seconds",
                "rate_units" : "calls/second"
              }
            }
          }
          
          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Here's an example output from /admin/metrics: { "version" : "3.0.0" , "gauges" : { "org.eclipse.jetty.server.handler.DefaultHandler.percent-4xx-15m" : { "value" : 0.0 }, "org.eclipse.jetty.server.handler.DefaultHandler.percent-4xx-1m" : { "value" : 0.0 }, "org.eclipse.jetty.server.handler.DefaultHandler.percent-4xx-5m" : { "value" : 0.0 }, "org.eclipse.jetty.server.handler.DefaultHandler.percent-5xx-15m" : { "value" : 0.0 }, "org.eclipse.jetty.server.handler.DefaultHandler.percent-5xx-1m" : { "value" : 0.0 }, "org.eclipse.jetty.server.handler.DefaultHandler.percent-5xx-5m" : { "value" : 0.0 }, "org.eclipse.jetty.util.thread.QueuedThreadPool.qtp707806938.jobs" : { "value" : 0 }, "org.eclipse.jetty.util.thread.QueuedThreadPool.qtp707806938.size" : { "value" : 10 }, "org.eclipse.jetty.util.thread.QueuedThreadPool.qtp707806938.utilization" : { "value" : 0.6 }, "org.eclipse.jetty.util.thread.QueuedThreadPool.qtp707806938.utilization-max" : { "value" : 6.0E-4 } }, "counters" : { "org.eclipse.jetty.server.handler.DefaultHandler.active-dispatches" : { "count" : 0 }, "org.eclipse.jetty.server.handler.DefaultHandler.active-requests" : { "count" : 0 }, "org.eclipse.jetty.server.handler.DefaultHandler.active-suspended" : { "count" : 0 } }, "histograms" : { }, "meters" : { "org.eclipse.jetty.server.handler.DefaultHandler.1xx-responses" : { "count" : 0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "units" : "events/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.2xx-responses" : { "count" : 6, "m15_rate" : 1.2, "m1_rate" : 1.2, "m5_rate" : 1.2, "mean_rate" : 0.8643507760595339, "units" : "events/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.3xx-responses" : { "count" : 0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "units" : "events/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.4xx-responses" : { "count" : 0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "units" : "events/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.5xx-responses" : { "count" : 0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "units" : "events/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.async-dispatches" : { "count" : 0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "units" : "events/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.async-timeouts" : { "count" : 0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "units" : "events/second" } }, "timers" : { "org.eclipse.jetty.server.handler.DefaultHandler.connect-requests" : { "count" : 0, "max" : 0.0, "mean" : 0.0, "min" : 0.0, "p50" : 0.0, "p75" : 0.0, "p95" : 0.0, "p98" : 0.0, "p99" : 0.0, "p999" : 0.0, "stddev" : 0.0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.delete-requests" : { "count" : 0, "max" : 0.0, "mean" : 0.0, "min" : 0.0, "p50" : 0.0, "p75" : 0.0, "p95" : 0.0, "p98" : 0.0, "p99" : 0.0, "p999" : 0.0, "stddev" : 0.0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.dispatches" : { "count" : 6, "max" : 1.05, "mean" : 0.1916620195600857, "min" : 0.002, "p50" : 0.01, "p75" : 0.062000000000000006, "p95" : 1.05, "p98" : 1.05, "p99" : 1.05, "p999" : 1.05, "stddev" : 0.3872921205929878, "m15_rate" : 1.2, "m1_rate" : 1.2, "m5_rate" : 1.2, "mean_rate" : 0.8639066608151542, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.get-requests" : { "count" : 6, "max" : 1.05, "mean" : 0.1916620195600857, "min" : 0.002, "p50" : 0.01, "p75" : 0.062000000000000006, "p95" : 1.05, "p98" : 1.05, "p99" : 1.05, "p999" : 1.05, "stddev" : 0.3872921205929878, "m15_rate" : 1.2, "m1_rate" : 1.2, "m5_rate" : 1.2, "mean_rate" : 0.8639236767111607, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.head-requests" : { "count" : 0, "max" : 0.0, "mean" : 0.0, "min" : 0.0, "p50" : 0.0, "p75" : 0.0, "p95" : 0.0, "p98" : 0.0, "p99" : 0.0, "p999" : 0.0, "stddev" : 0.0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.move-requests" : { "count" : 0, "max" : 0.0, "mean" : 0.0, "min" : 0.0, "p50" : 0.0, "p75" : 0.0, "p95" : 0.0, "p98" : 0.0, "p99" : 0.0, "p999" : 0.0, "stddev" : 0.0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.options-requests" : { "count" : 0, "max" : 0.0, "mean" : 0.0, "min" : 0.0, "p50" : 0.0, "p75" : 0.0, "p95" : 0.0, "p98" : 0.0, "p99" : 0.0, "p999" : 0.0, "stddev" : 0.0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.other-requests" : { "count" : 0, "max" : 0.0, "mean" : 0.0, "min" : 0.0, "p50" : 0.0, "p75" : 0.0, "p95" : 0.0, "p98" : 0.0, "p99" : 0.0, "p999" : 0.0, "stddev" : 0.0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.post-requests" : { "count" : 0, "max" : 0.0, "mean" : 0.0, "min" : 0.0, "p50" : 0.0, "p75" : 0.0, "p95" : 0.0, "p98" : 0.0, "p99" : 0.0, "p999" : 0.0, "stddev" : 0.0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.put-requests" : { "count" : 0, "max" : 0.0, "mean" : 0.0, "min" : 0.0, "p50" : 0.0, "p75" : 0.0, "p95" : 0.0, "p98" : 0.0, "p99" : 0.0, "p999" : 0.0, "stddev" : 0.0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.requests" : { "count" : 6, "max" : 1.05, "mean" : 0.1916620195600857, "min" : 0.002, "p50" : 0.01, "p75" : 0.062000000000000006, "p95" : 1.05, "p98" : 1.05, "p99" : 1.05, "p999" : 1.05, "stddev" : 0.3872921205929878, "m15_rate" : 1.2, "m1_rate" : 1.2, "m5_rate" : 1.2, "mean_rate" : 0.86372875919477, "duration_units" : "seconds" , "rate_units" : "calls/second" }, "org.eclipse.jetty.server.handler.DefaultHandler.trace-requests" : { "count" : 0, "max" : 0.0, "mean" : 0.0, "min" : 0.0, "p50" : 0.0, "p75" : 0.0, "p95" : 0.0, "p98" : 0.0, "p99" : 0.0, "p999" : 0.0, "stddev" : 0.0, "m15_rate" : 0.0, "m1_rate" : 0.0, "m5_rate" : 0.0, "mean_rate" : 0.0, "duration_units" : "seconds" , "rate_units" : "calls/second" } } }
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Changed the metric registry name to "/jetty" as per suggestion in SOLR-4735

          I am going to create a branch called "origin/feature/metrics" so that we can keep SOLR-9788, SOLR-4735 and other metrics improvements in sync.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Changed the metric registry name to "/jetty" as per suggestion in SOLR-4735 I am going to create a branch called "origin/feature/metrics" so that we can keep SOLR-9788 , SOLR-4735 and other metrics improvements in sync.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 497212e05451c11088fb4f04d1c8e6092915dc40 in lucene-solr's branch refs/heads/feature/metrics from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=497212e ]

          SOLR-9788: Use instrumented jetty classes provided by the dropwizard metric library. This also introduces a new /admin/metrics API endpoint to return all registered metrics in JSON format

          Show
          jira-bot ASF subversion and git services added a comment - Commit 497212e05451c11088fb4f04d1c8e6092915dc40 in lucene-solr's branch refs/heads/feature/metrics from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=497212e ] SOLR-9788 : Use instrumented jetty classes provided by the dropwizard metric library. This also introduces a new /admin/metrics API endpoint to return all registered metrics in JSON format
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1e1ae1ffa9994b4ec05a8fdd590dd5a6973c71c0 in lucene-solr's branch refs/heads/feature/metrics from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1e1ae1f ]

          SOLR-9788: Use "solr.jetty" as the metric registry name for jetty stats

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1e1ae1ffa9994b4ec05a8fdd590dd5a6973c71c0 in lucene-solr's branch refs/heads/feature/metrics from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1e1ae1f ] SOLR-9788 : Use "solr.jetty" as the metric registry name for jetty stats
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8bbdb6248c5de3f3bd61501ba42a50aeec29c78b in lucene-solr's branch refs/heads/master from Andrzej Bialecki
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8bbdb62 ]

          Squashed commit of branch 'feature/metrics', containing:
          SOLR-4735: Improve Solr metrics reporting
          SOLR-9812: Implement /admin/metrics API
          SOLR-9805: Use metrics-jvm library to instrument jvm internals
          SOLR-9788: Use instrumented jetty classes

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8bbdb6248c5de3f3bd61501ba42a50aeec29c78b in lucene-solr's branch refs/heads/master from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8bbdb62 ] Squashed commit of branch 'feature/metrics', containing: SOLR-4735 : Improve Solr metrics reporting SOLR-9812 : Implement /admin/metrics API SOLR-9805 : Use metrics-jvm library to instrument jvm internals SOLR-9788 : Use instrumented jetty classes
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9dde8a30303de4bce5da45189219dd6150252b29 in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9dde8a3 ]

          Cumulative patch from master, originally developed on branch
          'feature/metrics', which brings the following issues:

          • SOLR-4735: Improve Solr metrics reporting
          • SOLR-9812: Implement /admin/metrics API
          • SOLR-9805: Use metrics-jvm library to instrument jvm internals
          • SOLR-9788: Use instrumented jetty classes
          Show
          jira-bot ASF subversion and git services added a comment - Commit 9dde8a30303de4bce5da45189219dd6150252b29 in lucene-solr's branch refs/heads/branch_6x from Andrzej Bialecki [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9dde8a3 ] Cumulative patch from master, originally developed on branch 'feature/metrics', which brings the following issues: SOLR-4735 : Improve Solr metrics reporting SOLR-9812 : Implement /admin/metrics API SOLR-9805 : Use metrics-jvm library to instrument jvm internals SOLR-9788 : Use instrumented jetty classes

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              shalinmangar Shalin Shekhar Mangar
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development