[SOLR-9769] solr stop on a service already stopped should return exit code 0

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 6.3
• Component/s: scripts and tools
• Assignee: Unassigned
• Reporter: Jiří Pejchal
• Created: 15/Nov/16 14:18
• Updated: 16/Apr/20 19:35

Description

According to the LSB specification
https://refspecs.linuxfoundation.org/LSB_4.0.0/LSB-Core-generic/LSB-Core-generic.html#INISCRPTACT
running stop on a service already stopped or not running should be considered successful and return code should be 0 (zero).

Solr currently returns exit code 1:

$ /etc/init.d/solr stop; echo $?
Sending stop command to Solr running on port 8983 ... waiting up to 180 seconds to allow Jetty process 4277 to stop gracefully.
0
$ /etc/init.d/solr stop; echo $?
No process found for Solr node running on port 8983
1

"bin/solr"

if [ "$SOLR_PID" != "" ]; then
    stop_solr "$SOLR_SERVER_DIR" "$SOLR_PORT" "$STOP_KEY" "$SOLR_PID"
  else
    if [ "$SCRIPT_CMD" == "stop" ]; then
      echo -e "No process found for Solr node running on port $SOLR_PORT"
      exit 1
    fi
  fi

Issue Links

• is fixed by: SOLR-14410 Switch from SysV init script to systemd service definition
• links to: GitHub Pull Request #378