Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9758

refactor preferLocalShards implementation

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      This ticket proposes to refactor the existing preferLocalShards implementation (from SOLR-6832 and SOLR-8298) based upon the recent (in SOLR-8332) ReplicaListTransformer addition.

      The intention of the refactor is to encapsulate the local shard url selection logic within the HttpShardHandlerFactory.getReplicaListTransformer method (it is currently spread across the public HttpShardHandler.prepDistributed and the private HttpShardHandler.getURLs method) and to thus remove the ResponseBuilder.preferredHostAddress field.

      1. SOLR-9758.patch
        14 kB
        Christine Poerschke

        Issue Links

          Activity

          Hide
          cpoerschke Christine Poerschke added a comment -

          Timothy Potter and/or Noble Paul - would you have some time to review the proposed change? Am hoping to commit it early December or so ideally. Thanks!

          Show
          cpoerschke Christine Poerschke added a comment - Timothy Potter and/or Noble Paul - would you have some time to review the proposed change? Am hoping to commit it early December or so ideally. Thanks!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit de0a046b21b7c8698fff0db685eb287e24087b22 in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=de0a046 ]

          SOLR-9758: refactor preferLocalShards implementation

          Show
          jira-bot ASF subversion and git services added a comment - Commit de0a046b21b7c8698fff0db685eb287e24087b22 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=de0a046 ] SOLR-9758 : refactor preferLocalShards implementation
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 121f50c84dc48c95685fcbd7b64d5ca7e8d3a6c9 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=121f50c ]

          SOLR-9758: refactor preferLocalShards implementation

          Show
          jira-bot ASF subversion and git services added a comment - Commit 121f50c84dc48c95685fcbd7b64d5ca7e8d3a6c9 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=121f50c ] SOLR-9758 : refactor preferLocalShards implementation

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              cpoerschke Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development