Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      JDBCStream has a few items that can be improved:

      • IOExceptions don't have the expression in the message
      • Use .equals() when comparing class names
      • Use .getColumnLabel instead of .getColumnName when working with SQL ResultSet to make sure AS is properly handled.
      1. SOLR-9729.patch
        14 kB
        Kevin Risden
      2. SOLR-9729.patch
        12 kB
        Kevin Risden

        Activity

        Hide
        risdenk Kevin Risden added a comment -

        Patch fixing described items. Dennis Gove do these changes make sense to you?

        Show
        risdenk Kevin Risden added a comment - Patch fixing described items. Dennis Gove do these changes make sense to you?
        Hide
        risdenk Kevin Risden added a comment -

        Well on second look the get_column_name is doing the right thing. I'll remove the getColumnLabel change.

        Show
        risdenk Kevin Risden added a comment - Well on second look the get_column_name is doing the right thing. I'll remove the getColumnLabel change.
        Hide
        risdenk Kevin Risden added a comment -

        Well now I'm confused. I really think that JDBCStream should be using getColumnLabel since that makes AS queries work correctly. The hsqldb get_column_name parameter seems to be able to change that behavior which doesn't make sense. The default value of true is correct. I think the tests need to be fixed to not rely on get_column_name.

        Show
        risdenk Kevin Risden added a comment - Well now I'm confused. I really think that JDBCStream should be using getColumnLabel since that makes AS queries work correctly. The hsqldb get_column_name parameter seems to be able to change that behavior which doesn't make sense. The default value of true is correct. I think the tests need to be fixed to not rely on get_column_name.
        Hide
        risdenk Kevin Risden added a comment -

        Updated patch to fix JDBStreamTest to not rely on get_column_name parameter from hsqldb.

        Show
        risdenk Kevin Risden added a comment - Updated patch to fix JDBStreamTest to not rely on get_column_name parameter from hsqldb.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c20d1298d3b26482dfc46a557d9c0680ce84aaed in lucene-solr's branch refs/heads/master from Kevin Risden
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c20d129 ]

        SOLR-9729: JDBCStream improvements

        Show
        jira-bot ASF subversion and git services added a comment - Commit c20d1298d3b26482dfc46a557d9c0680ce84aaed in lucene-solr's branch refs/heads/master from Kevin Risden [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c20d129 ] SOLR-9729 : JDBCStream improvements
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8af0223812946e3d5d2bf455316065a00c3457e6 in lucene-solr's branch refs/heads/branch_6x from Kevin Risden
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8af0223 ]

        SOLR-9729: JDBCStream improvements

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8af0223812946e3d5d2bf455316065a00c3457e6 in lucene-solr's branch refs/heads/branch_6x from Kevin Risden [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8af0223 ] SOLR-9729 : JDBCStream improvements

          People

          • Assignee:
            risdenk Kevin Risden
            Reporter:
            risdenk Kevin Risden
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development