Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9726

DocValuesFacets: move 'contains' check after 'min' check

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None
    • Flags:
      Patch

      Description

      If a query requests facets with a 'contains' check, DocValuesFacets converts each term's ordinal to a BytesRef, does the string match and then checks whether it has a high enough count to go in the priority queue.
      This patch moves the lookup after the min check so that we don't do it for all terms.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cbf8235e570c8f10f42eb1240f7e0d5918e7025c in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cbf8235 ]

        SOLR-9726: Reduce number of lookupOrd calls made by the DocValuesFacets.getCounts method. (Jonny Marks via Christine Poerschke)

        Show
        jira-bot ASF subversion and git services added a comment - Commit cbf8235e570c8f10f42eb1240f7e0d5918e7025c in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cbf8235 ] SOLR-9726 : Reduce number of lookupOrd calls made by the DocValuesFacets.getCounts method. (Jonny Marks via Christine Poerschke)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1c7ae9215cbb276a89ae17fd95a43c54ef582a68 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1c7ae92 ]

        SOLR-9726: Reduce number of lookupOrd calls made by the DocValuesFacets.getCounts method. (Jonny Marks via Christine Poerschke)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1c7ae9215cbb276a89ae17fd95a43c54ef582a68 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1c7ae92 ] SOLR-9726 : Reduce number of lookupOrd calls made by the DocValuesFacets.getCounts method. (Jonny Marks via Christine Poerschke)
        Hide
        cpoerschke Christine Poerschke added a comment -

        Thanks Jonny!

        Show
        cpoerschke Christine Poerschke added a comment - Thanks Jonny!

          People

          • Assignee:
            cpoerschke Christine Poerschke
            Reporter:
            jm100 Jonny Marks
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development