[SOLR-9725] Allow Variables for All Data Import Handler Data Source Configuration Values

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.5.3
• Fix Version/s: 6.4, 7.0
• Component/s: contrib - DataImportHandler
• Labels: patch
• Assignee: Mikhail Khludnev
• Reporter: Jamie Jackson
• Created: 03/Nov/16 18:48
• Updated: 08/Jun/19 15:30
• Resolved: 27/Dec/16 20:09

Description

I need to be able to use a variable for a password when also using encryptKeyFile.

For instance:

	<dataSource
		driver="${custom.dataimporter.datasource.driver}"
		url="${custom.dataimporter.datasource.url}"
		user="${custom.dataimporter.datasource.user}"
		password="${custom.dataimporter.datasource.password}"
		encryptKeyFile="/opt/solr/credentials/encrypt.key"
	/>

Because I need to change certain variables based on the environment. I'd start like this:

     -a
      -Dcustom.dataimporter.datasource.driver=org.mariadb.jdbc.Driver
      -Dcustom.dataimporter.datasource.url=jdbc:mysql://local.mysite.com:3306/mysite
      -Dcustom.dataimporter.datasource.user=root
      -Dcustom.dataimporter.datasource.password=U2FsdGVkX1/dqwTb8RBfFq82SM37DkDRGeWMOndftHY=

If I hardcode the password, it works; if I use a variable reference, it doesn't.

As far as I know this pull request was submitted to address this issue, but it didn't come with a Jira ticket or a full explanation.

Also, note that I'm not using a variable for the value of encryptKeyFile, because it's not possible in 5.x, though it seems to be fixed in 6.1. Presumably, the above patch would encompass encryptKeyFile's value, as well.

Issue Links

• is related to: SOLR-9771 Resolv Variables in DIH when using encryptKeyFile.
• relates to: SOLR-8610 DIH - Resolve variables in encryptKeyFile
• links to: GitHub Pull Request #46
• links to: GitHub Pull Request #112