Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      The Response JSON is written in an ad hoc way. Standardize the way the docs are written and support javabin as well

        Issue Links

          Activity

          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          A related thought I've had for some time... it seems like the xport/xsort, etc, is really all about implementation (performance, optimization) and not about interface (retrieving a list of documents).
          It seems like we should be able to simply apply optimizations (these and/or others) to the standard query component and standard response writers to make them just as fast?

          I don't meant to derail this issue though.... it may still make sense to add javabin support to xsort in the short term even if it becomes deprecated in the long run.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - A related thought I've had for some time... it seems like the xport/xsort, etc, is really all about implementation (performance, optimization) and not about interface (retrieving a list of documents). It seems like we should be able to simply apply optimizations (these and/or others) to the standard query component and standard response writers to make them just as fast? I don't meant to derail this issue though.... it may still make sense to add javabin support to xsort in the short term even if it becomes deprecated in the long run.
          Hide
          noble.paul Noble Paul added a comment -

          Yeah. It was a bad idea to have a different response writer for this purpose. I shall fold this retrieval code to the export handler so that it can work with all response writers

          Show
          noble.paul Noble Paul added a comment - Yeah. It was a bad idea to have a different response writer for this purpose. I shall fold this retrieval code to the export handler so that it can work with all response writers
          Hide
          noble.paul Noble Paul added a comment -

          refactored so that the response writing is abstracted out.

          Show
          noble.paul Noble Paul added a comment - refactored so that the response writing is abstracted out.
          Hide
          noble.paul Noble Paul added a comment - - edited

          What's included

          • The SortingResponseWriter (xsort) does not exist and it is now moved to a generic class called ExportWriter
          • ExportWriter does not emit JSON. it uses an interface called PushWriter to write response
          • TextResponseWriter implements PushWriter and in turn JSONWriter also implements PushWriter
          • The path /export is now handled by a class called ExportHandler which just sets the appropriate wt and invoke ExportWriter to spit out the response
          Show
          noble.paul Noble Paul added a comment - - edited What's included The SortingResponseWriter (xsort) does not exist and it is now moved to a generic class called ExportWriter ExportWriter does not emit JSON. it uses an interface called PushWriter to write response TextResponseWriter implements PushWriter and in turn JSONWriter also implements PushWriter The path /export is now handled by a class called ExportHandler which just sets the appropriate wt and invoke ExportWriter to spit out the response
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e6dfb76c98048d3dc3aec85b9aaeb2a6e9f1d6a8 in lucene-solr's branch refs/heads/branch_6x from Noble Paul
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e6dfb76 ]

          SOLR-9717: Refactor '/export' to not hardcode the JSON output and to use an API

          Show
          jira-bot ASF subversion and git services added a comment - Commit e6dfb76c98048d3dc3aec85b9aaeb2a6e9f1d6a8 in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e6dfb76 ] SOLR-9717 : Refactor '/export' to not hardcode the JSON output and to use an API
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ef074a61f855c37cd82de699d13ac31310a8d63e in lucene-solr's branch refs/heads/master from Noble Paul
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ef074a6 ]

          SOLR-9717: Refactor '/export' to not hardcode the JSON output and to use an API

          Show
          jira-bot ASF subversion and git services added a comment - Commit ef074a61f855c37cd82de699d13ac31310a8d63e in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ef074a6 ] SOLR-9717 : Refactor '/export' to not hardcode the JSON output and to use an API
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6abfad0234f677c5802fec9a1501dcb3773b3d03 in lucene-solr's branch refs/heads/master from Noble Paul
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6abfad0 ]

          SOLR-9717: Refactor '/export' to not hardcode the JSON output and to use an API

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6abfad0234f677c5802fec9a1501dcb3773b3d03 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6abfad0 ] SOLR-9717 : Refactor '/export' to not hardcode the JSON output and to use an API

            People

            • Assignee:
              noble.paul Noble Paul
              Reporter:
              noble.paul Noble Paul
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development