Solr
  1. Solr
  2. SOLR-970

SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - replacing LinkedList with ArrayList for the internal impl of return type

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None
    • Environment:

      Java 6, Tomcat 6

      Description

      Is there a specific reason to use LinkedList for the internal implementation of List<?> .

      ArrayList provides a better locality of reference than a LinkedList . Addition at the end of the list ( the default behavior of .add() ) is expensive for LinkedList again.

      1. SOLR-970.patch
        0.7 kB
        Karthik K

        Activity

        Hide
        Hoss Man added a comment -

        nice catch Kay

        Committed revision 737464.

        Show
        Hoss Man added a comment - nice catch Kay Committed revision 737464.
        Hide
        Karthik K added a comment -

        Thanks .

        Show
        Karthik K added a comment - Thanks .

          People

          • Assignee:
            Hoss Man
            Reporter:
            Karthik K
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 5m
              5m
              Remaining:
              Remaining Estimate - 5m
              5m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development