Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9692

BlockUnknown property still breaks the internode communication

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)

      Description

      This is still broken after fixing SOLR-9188

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6d9a99f99264b32cd5547dfe6f5db9862fd84bda in lucene-solr's branch refs/heads/master from Noble Paul
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6d9a99f ]

          SOLR-9692: blockUnknown property still breaks the internode communication

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6d9a99f99264b32cd5547dfe6f5db9862fd84bda in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6d9a99f ] SOLR-9692 : blockUnknown property still breaks the internode communication
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ecb3ea2dab3ed8a65f983d7dcbf5fc65ef60ca57 in lucene-solr's branch refs/heads/branch_6x from Noble Paul
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ecb3ea2 ]

          SOLR-9692: blockUnknown property still breaks the internode communication

          Show
          jira-bot ASF subversion and git services added a comment - Commit ecb3ea2dab3ed8a65f983d7dcbf5fc65ef60ca57 in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ecb3ea2 ] SOLR-9692 : blockUnknown property still breaks the internode communication
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8f3f1f3ebb946eccd1ef1e102d1e3b1db02f031a in lucene-solr's branch refs/heads/branch_6x from Noble Paul
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8f3f1f3 ]

          SOLR-9692: blockUnknown property still breaks the internode communication

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8f3f1f3ebb946eccd1ef1e102d1e3b1db02f031a in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8f3f1f3 ] SOLR-9692 : blockUnknown property still breaks the internode communication
          Hide
          janhoy Jan Høydahl added a comment -

          In CHANGES.txt you just removed the entry for SOLR-9188. I believe you did not mean to rewrite the history of a released product, but instead ADD SOLR-9692?

          Show
          janhoy Jan Høydahl added a comment - In CHANGES.txt you just removed the entry for SOLR-9188 . I believe you did not mean to rewrite the history of a released product, but instead ADD SOLR-9692 ?
          Hide
          noble.paul Noble Paul added a comment -

          I'm super confused about this now. it was added to 6.2.1 where it did not fix it. if somebody takes a look at CHANGES.txt sometime in the future it is not actually fixed in 6.2.1.

          My preference is to remove that entry from the 6.2.1 section and add it only to 6.3

          Show
          noble.paul Noble Paul added a comment - I'm super confused about this now. it was added to 6.2.1 where it did not fix it. if somebody takes a look at CHANGES.txt sometime in the future it is not actually fixed in 6.2.1. My preference is to remove that entry from the 6.2.1 section and add it only to 6.3
          Hide
          janhoy Jan Høydahl added a comment -

          Hmm, now I also got a bit confused as to what our policy is for this. We have earlier released half-baked fixes that received more commits in a later release, but I don't think we have removed changes entries?
          There was some code that went in with that commit to SOLR-9188, so perhaps instead change the wording of the changes entry to reflect what it actually did?

          Show
          janhoy Jan Høydahl added a comment - Hmm, now I also got a bit confused as to what our policy is for this. We have earlier released half-baked fixes that received more commits in a later release, but I don't think we have removed changes entries? There was some code that went in with that commit to SOLR-9188 , so perhaps instead change the wording of the changes entry to reflect what it actually did?
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d9c4846ee17c18114843e01a6319b31033a4d3a9 in lucene-solr's branch refs/heads/master from Noble Paul
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d9c4846 ]

          SOLR-9692: blockUnknown property makes inter-node communication impossible

          Show
          jira-bot ASF subversion and git services added a comment - Commit d9c4846ee17c18114843e01a6319b31033a4d3a9 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d9c4846 ] SOLR-9692 : blockUnknown property makes inter-node communication impossible
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8c020e395b761ad967855ab94731925836389aeb in lucene-solr's branch refs/heads/branch_6x from Noble Paul
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8c020e3 ]

          SOLR-9692: blockUnknown property makes inter-node communication impossible

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8c020e395b761ad967855ab94731925836389aeb in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8c020e3 ] SOLR-9692 : blockUnknown property makes inter-node communication impossible
          Hide
          janhoy Jan Høydahl added a comment -

          Wondering whether this patch was ever tested outside the test environment? Ewen Cluley did you have a chance to test it?

          Just seeing when testing another issue that the two methods getServletPath and getPathInfo do not always return the same string, so a more reliable way would be to use getRequestURI and check for .endsWith() instead of equals. See this article for reference http://stackoverflow.com/a/21046620/416763

          Or perhaps someone can spin up the 6.3 RC and test this by hand, outside the unit tests? I don't have time right now.

          Show
          janhoy Jan Høydahl added a comment - Wondering whether this patch was ever tested outside the test environment? Ewen Cluley did you have a chance to test it? Just seeing when testing another issue that the two methods getServletPath and getPathInfo do not always return the same string, so a more reliable way would be to use getRequestURI and check for .endsWith() instead of equals. See this article for reference http://stackoverflow.com/a/21046620/416763 Or perhaps someone can spin up the 6.3 RC and test this by hand, outside the unit tests? I don't have time right now.
          Hide
          noble.paul Noble Paul added a comment -

          I did manual testing. The problem was different methods work in different scenarios.

          Show
          noble.paul Noble Paul added a comment - I did manual testing. The problem was different methods work in different scenarios.
          Hide
          janhoy Jan Høydahl added a comment -

          Yea, did a quick test, looks OK.

          Show
          janhoy Jan Høydahl added a comment - Yea, did a quick test, looks OK.
          Hide
          ewencluley Ewen Cluley added a comment -

          I have not had a chance to test it yet, will try to do a build of 6.3 rc with my setup over the next few days.

          Show
          ewencluley Ewen Cluley added a comment - I have not had a chance to test it yet, will try to do a build of 6.3 rc with my setup over the next few days.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Closing after 6.3.0 release.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

            People

            • Assignee:
              noble.paul Noble Paul
              Reporter:
              noble.paul Noble Paul
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development