Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9687

Values not assigned to all valid Interval Facet intervals in some cases

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.3.1
    • Fix Version/s: 6.3, 7.0
    • Component/s: faceting
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Using the interval facet definitions:

      • {!key=Positive}(0,*]
      • {!key=Zero}[0,0]
      • {!key=Negative}(*,0)

      A document with the value "0" in the numeric field the intervals are being applied to is not counted in the Zero interval. If I change the order of the definitions to , Negative, Zero, Positive the "0" value is correctly counted in the Zero interval.

      Tracing into the 5.3.1 code the problem is in the org.apache.solr.request.IntervalFacets class. When the getSortedIntervals() method sorts the interval definitions for a field by their starting value is doesn't take into account the startOpen property. When two intervals have equal start values it needs to sort intervals where startOpen == false before intervals where startOpen == true.

      In the accumIntervalWithValue() method it checks which intervals each document value should be considered a match for. It iterates through the sorted intervals and stops checking subsequent intervals when LOWER_THAN_START result is returned. If the Positive interval is sorted before the Zero interval it never checks a zero value against the Zero interval.

      I compared the 5.3.1 version of the IntervalFacets class against the 6.2.1 code, and it looks like the same issue will occur in 6.2.1.

        Attachments

        1. SOLR-9687.patch
          2 kB
          Tomás Fernández Löbbe

          Activity

            People

            • Assignee:
              tomasflobbe Tomás Fernández Löbbe
              Reporter:
              andycsolr Andy Chillrud
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: