Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9654

add overrequest parameter to field faceting

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, 7.0
    • Component/s: Facet Module
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Add an "overrequest" parameter that can control the amount of overrequest done for distributed search. Among other things, this parameter will aid in testing simple refinement cases.

      1. SOLR-9654.patch
        7 kB
        Yonik Seeley
      2. SOLR-9654.patch
        4 kB
        Yonik Seeley

        Activity

        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Here's a draft patch w/o tests

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Here's a draft patch w/o tests
        Hide
        dsmiley David Smiley added a comment -

        +1.
        BTW it would be helpful if in the issue title you disambiguated which facet implmentation this is for . To others reading, this is for the JSON Facets impl.

        Show
        dsmiley David Smiley added a comment - +1. BTW it would be helpful if in the issue title you disambiguated which facet implmentation this is for . To others reading, this is for the JSON Facets impl.
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Patch now with tests, and with a fix for overflow of offset+limit

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Patch now with tests, and with a fix for overflow of offset+limit
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        It may not stand out much, but Component=="Facet Module" means JSON Facet API

        Show
        yseeley@gmail.com Yonik Seeley added a comment - It may not stand out much, but Component=="Facet Module" means JSON Facet API
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4a85163754e16b466cb4ef3dd0de92fe7d5b87d1 in lucene-solr's branch refs/heads/master from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4a85163 ]

        SOLR-9654: add overrequest param to JSON Facet API

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4a85163754e16b466cb4ef3dd0de92fe7d5b87d1 in lucene-solr's branch refs/heads/master from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4a85163 ] SOLR-9654 : add overrequest param to JSON Facet API
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a27897d81bd2e2cfad1dad0a6cb5b94d638a6851 in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a27897d ]

        SOLR-9654: add overrequest param to JSON Facet API

        Show
        jira-bot ASF subversion and git services added a comment - Commit a27897d81bd2e2cfad1dad0a6cb5b94d638a6851 in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a27897d ] SOLR-9654 : add overrequest param to JSON Facet API
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        investigating failing test

        Show
        yseeley@gmail.com Yonik Seeley added a comment - investigating failing test
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c9132ac66100ab46bea480397396105f8489b239 in lucene-solr's branch refs/heads/master from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c9132ac ]

        SOLR-9654: tests: specify descending count sort for streaming

        Show
        jira-bot ASF subversion and git services added a comment - Commit c9132ac66100ab46bea480397396105f8489b239 in lucene-solr's branch refs/heads/master from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c9132ac ] SOLR-9654 : tests: specify descending count sort for streaming
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e06c60dd9dfa23c1eac2a95cabbeb2269c23f1cf in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e06c60d ]

        SOLR-9654: tests: specify descending count sort for streaming

        Show
        jira-bot ASF subversion and git services added a comment - Commit e06c60dd9dfa23c1eac2a95cabbeb2269c23f1cf in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e06c60d ] SOLR-9654 : tests: specify descending count sort for streaming
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Hopefully should be fixed now.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Hopefully should be fixed now.
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Hmmm, still failing sometimes... I'll remove the offending code while I figure it out.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Hmmm, still failing sometimes... I'll remove the offending code while I figure it out.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e4483607a58c68df6a8ea0c7cb107bf2f8707a45 in lucene-solr's branch refs/heads/master from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e448360 ]

        SOLR-9654: tests: temporarily disable overrequest code

        Show
        jira-bot ASF subversion and git services added a comment - Commit e4483607a58c68df6a8ea0c7cb107bf2f8707a45 in lucene-solr's branch refs/heads/master from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e448360 ] SOLR-9654 : tests: temporarily disable overrequest code
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2574e3ca70402adb49b58b1ae2edf9d962b1d4b3 in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2574e3c ]

        SOLR-9654: tests: temporarily disable overrequest code

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2574e3ca70402adb49b58b1ae2edf9d962b1d4b3 in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2574e3c ] SOLR-9654 : tests: temporarily disable overrequest code
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 53507b4e79573af3fdc64207b9e47d62f7c99028 in lucene-solr's branch refs/heads/master from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53507b4 ]

        SOLR-9654: tests: fix overrequest test by fixing doc->shard mapping

        Show
        jira-bot ASF subversion and git services added a comment - Commit 53507b4e79573af3fdc64207b9e47d62f7c99028 in lucene-solr's branch refs/heads/master from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53507b4 ] SOLR-9654 : tests: fix overrequest test by fixing doc->shard mapping
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bbc31894738237ec6f6c1f061debfc837955c953 in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bbc3189 ]

        SOLR-9654: tests: fix overrequest test by fixing doc->shard mapping

        Show
        jira-bot ASF subversion and git services added a comment - Commit bbc31894738237ec6f6c1f061debfc837955c953 in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bbc3189 ] SOLR-9654 : tests: fix overrequest test by fixing doc->shard mapping
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        The id-to-shard mapping of these tests is randomized by run, so I changed the test to add documents to specific shards.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - The id-to-shard mapping of these tests is randomized by run, so I changed the test to add documents to specific shards.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            yseeley@gmail.com Yonik Seeley
            Reporter:
            yseeley@gmail.com Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development