also, it's worth to remove @RandomSSL from HttpSolrClientSSLAuthConPoolTest to make it really random.
I think it's worth keeping the RandomizeSSL annotation on this test though, as it's only really applicable to SSL+clientAuth situations.
Agreed, but I think I also see Mikhail's point: from a coverage standpoint, it would be nice to have a test that helps ensure we are re-using connection pools regardless of whether SSL+clientAuth is used or not (ie: as the test stands now, we only ensure they are re-used with SSL, some future bug could break connection re-use for non-ssl connections and we'd never know – heck: in theory the changes in this fix for SSL connection reuse could be breaking connection reuse for non-SSL requests, and we wouldn't know it.)
So perhaps refactor the current HttpSolrClientSSLAuthConPoolTest class into a HttpSolrClientConPoolTest that uses the default SSL randomization, and then make HttpSolrClientSSLAuthConPoolTest a subclass that forces @RandomizeSSL(1.0) ?
(along with a "test the test" sanity assertion that the urls start with "https")