Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9589

Review and remove Jackson dependency from SolrJ

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None
    1. SOLR-9589.patch
      2 kB
      Ishan Chattopadhyaya
    2. SOLR-9589.patch
      2 kB
      Ishan Chattopadhyaya

      Activity

      Hide
      ichattopadhyaya Ishan Chattopadhyaya added a comment - - edited

      Here's a patch for the removal of Jackson from SolrJ. David Smiley, Gregory Chanan, Noble Paul, please review.
      TestDelegationTokenResponse passes. I am running the full suite right now.

      Show
      ichattopadhyaya Ishan Chattopadhyaya added a comment - - edited Here's a patch for the removal of Jackson from SolrJ. David Smiley , Gregory Chanan , Noble Paul , please review. TestDelegationTokenResponse passes. I am running the full suite right now.
      Hide
      ichattopadhyaya Ishan Chattopadhyaya added a comment -

      The test suite ran without any new failures. The ones I saw are the same ones I keep seeing fail on my box. I think this should be good to go with.

      Show
      ichattopadhyaya Ishan Chattopadhyaya added a comment - The test suite ran without any new failures. The ones I saw are the same ones I keep seeing fail on my box. I think this should be good to go with.
      Hide
      hgadre Hrishikesh Gadre added a comment -

      Ishan Chattopadhyaya patch looks good to me!

      Show
      hgadre Hrishikesh Gadre added a comment - Ishan Chattopadhyaya patch looks good to me!
      Hide
      dsmiley David Smiley added a comment -

      +1 nice Ishan.

      This triviality of this patch underscores my amazement how we let Jackson become a dependency in the first place. Of course Jackson is very powerful but that power wasn't used in SolrJ (otherwise this wouldn't be a trivial patch).

      Show
      dsmiley David Smiley added a comment - +1 nice Ishan. This triviality of this patch underscores my amazement how we let Jackson become a dependency in the first place. Of course Jackson is very powerful but that power wasn't used in SolrJ (otherwise this wouldn't be a trivial patch).
      Hide
      thetaphi Uwe Schindler added a comment -

      +1

      Show
      thetaphi Uwe Schindler added a comment - +1
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 5fbf135b8058e773275febba4baa8fa4a42e6ffc in lucene-solr's branch refs/heads/master from Noble Paul
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5fbf135 ]

      Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/lucene-solr

      SOLR-9589: Remove jackson dependency from SolrJ

      Show
      jira-bot ASF subversion and git services added a comment - Commit 5fbf135b8058e773275febba4baa8fa4a42e6ffc in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5fbf135 ] Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/lucene-solr SOLR-9589 : Remove jackson dependency from SolrJ
      Hide
      epugh Eric Pugh added a comment -

      I updated to the 6.2.2-SNAPSHOT, as I ran into a dropwizard/SolrJ conflict on Jackson!

      However, both 6.2.2-SNAPSHOT and 6.3.0-SNAPSHOT pom files still include Jackson. So I had to add exclusions as below. Is there a code change to get updated .pom files on nightly?

      ```
      <dependency>
      <groupId>org.apache.solr</groupId>
      <artifactId>solr-solrj</artifactId>
      <version>6.2.2-SNAPSHOT</version>
      <exclusions>
      <exclusion> <!-- declare the exclusion here -->
      <groupId>com.fasterxml.jackson.core</groupId>
      <artifactId>jackson-core</artifactId>
      </exclusion>
      <exclusion> <!-- declare the exclusion here -->
      <groupId>com.fasterxml.jackson.core</groupId>
      <artifactId>jackson-annotations</artifactId>
      </exclusion>
      <exclusion> <!-- declare the exclusion here -->
      <groupId>com.fasterxml.jackson.core</groupId>
      <artifactId>jackson-databind</artifactId>
      </exclusion>
      </exclusions>
      </dependency>
      ```

      https://repository.apache.org/content/groups/snapshots/org/apache/solr/solr-solrj/6.3.0-SNAPSHOT/solr-solrj-6.3.0-20161002.040738-18.pom

      Show
      epugh Eric Pugh added a comment - I updated to the 6.2.2-SNAPSHOT, as I ran into a dropwizard/SolrJ conflict on Jackson! However, both 6.2.2-SNAPSHOT and 6.3.0-SNAPSHOT pom files still include Jackson. So I had to add exclusions as below. Is there a code change to get updated .pom files on nightly? ``` <dependency> <groupId>org.apache.solr</groupId> <artifactId>solr-solrj</artifactId> <version>6.2.2-SNAPSHOT</version> <exclusions> <exclusion> <!-- declare the exclusion here --> <groupId>com.fasterxml.jackson.core</groupId> <artifactId>jackson-core</artifactId> </exclusion> <exclusion> <!-- declare the exclusion here --> <groupId>com.fasterxml.jackson.core</groupId> <artifactId>jackson-annotations</artifactId> </exclusion> <exclusion> <!-- declare the exclusion here --> <groupId>com.fasterxml.jackson.core</groupId> <artifactId>jackson-databind</artifactId> </exclusion> </exclusions> </dependency> ``` https://repository.apache.org/content/groups/snapshots/org/apache/solr/solr-solrj/6.3.0-SNAPSHOT/solr-solrj-6.3.0-20161002.040738-18.pom
      Hide
      shalinmangar Shalin Shekhar Mangar added a comment -

      Closing after 6.3.0 release.

      Show
      shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

        People

        • Assignee:
          noble.paul Noble Paul
          Reporter:
          ichattopadhyaya Ishan Chattopadhyaya
        • Votes:
          0 Vote for this issue
          Watchers:
          7 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development