Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9588

Review and remove Guava dependency from SolrJ

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None
    1. SOLR-9588.patch
      6 kB
      Ishan Chattopadhyaya
    2. SOLR-9588.patch
      6 kB
      Ishan Chattopadhyaya
    3. SOLR-9588.patch
      6 kB
      Ishan Chattopadhyaya

      Activity

      Hide
      ichattopadhyaya Ishan Chattopadhyaya added a comment -

      The usages:

      1. @VisibleForTesting
      2. ImmutableList (ImplicitSnitch)
      3. ImmutableSet (Snitch, ImplicitSnitch)

      Added a patch to remove Guava dependency from SolrJ.

      Show
      ichattopadhyaya Ishan Chattopadhyaya added a comment - The usages: @VisibleForTesting ImmutableList (ImplicitSnitch) ImmutableSet (Snitch, ImplicitSnitch) Added a patch to remove Guava dependency from SolrJ.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 6f7099233ecef8e79eb5914cb17649309f84a6c9 in lucene-solr's branch refs/heads/master from Noble Paul
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6f70992 ]

      SOLR-9588: Remove Guava dependency from SolrJ

      Show
      jira-bot ASF subversion and git services added a comment - Commit 6f7099233ecef8e79eb5914cb17649309f84a6c9 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6f70992 ] SOLR-9588 : Remove Guava dependency from SolrJ
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit c067df413666074092f225481d2c0c880c5afb24 in lucene-solr's branch refs/heads/branch_6x from Noble Paul
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c067df4 ]

      SOLR-9588: Remove Guava dependency from SolrJ

      Show
      jira-bot ASF subversion and git services added a comment - Commit c067df413666074092f225481d2c0c880c5afb24 in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c067df4 ] SOLR-9588 : Remove Guava dependency from SolrJ
      Hide
      arafalov Alexandre Rafalovitch added a comment -

      This seems to have broken 6.x build for the SOLR-9344's code:

      common.compile-core:
          [javac] Compiling 299 source files to /Users/arafalov/ApacheDevelopment/lucene-6x/solr/build/solr-solrj/classes/java
          [javac] /Users/arafalov/ApacheDevelopment/lucene-6x/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java:30: error: package com.google.common.collect does not exist
          [javac] import com.google.common.collect.Lists;
          [javac]                                 ^
          [javac] /Users/arafalov/ApacheDevelopment/lucene-6x/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java:98: error: cannot find symbol
          [javac]       = Collections.synchronizedList(Lists.newArrayList(new HttpClientConfigurer()));
          [javac]                                      ^
          [javac]   symbol:   variable Lists
          [javac]   location: class HttpClientUtil
      
      Show
      arafalov Alexandre Rafalovitch added a comment - This seems to have broken 6.x build for the SOLR-9344 's code: common.compile-core: [javac] Compiling 299 source files to /Users/arafalov/ApacheDevelopment/lucene-6x/solr/build/solr-solrj/classes/java [javac] /Users/arafalov/ApacheDevelopment/lucene-6x/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java:30: error: package com.google.common.collect does not exist [javac] import com.google.common.collect.Lists; [javac] ^ [javac] /Users/arafalov/ApacheDevelopment/lucene-6x/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java:98: error: cannot find symbol [javac] = Collections.synchronizedList(Lists.newArrayList(new HttpClientConfigurer())); [javac] ^ [javac] symbol: variable Lists [javac] location: class HttpClientUtil
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 0aca05311042045d34970da1fde2b2156bcd858d in lucene-solr's branch refs/heads/branch_6x from Noble Paul
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0aca053 ]

      SOLR-9588: more guava dependency

      Show
      jira-bot ASF subversion and git services added a comment - Commit 0aca05311042045d34970da1fde2b2156bcd858d in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0aca053 ] SOLR-9588 : more guava dependency
      Hide
      ichattopadhyaya Ishan Chattopadhyaya added a comment -

      I'm looking into the failure.

      Show
      ichattopadhyaya Ishan Chattopadhyaya added a comment - I'm looking into the failure.
      Hide
      ichattopadhyaya Ishan Chattopadhyaya added a comment -

      The last commit fixed the failure on branch_6x.

      Show
      ichattopadhyaya Ishan Chattopadhyaya added a comment - The last commit fixed the failure on branch_6x.
      Hide
      dsmiley David Smiley added a comment -

      Thanks for cleaning this mess up Ishan Chattopadhyaya and Noble Paul!

      Show
      dsmiley David Smiley added a comment - Thanks for cleaning this mess up Ishan Chattopadhyaya and Noble Paul !
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 6ce4bbd2c25310a10b1e46adcbc1c99da1e7878a in lucene-solr's branch refs/heads/branch_6x from Noble Paul
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6ce4bbd ]

      SOLR-9588: removed guava dependency

      Show
      jira-bot ASF subversion and git services added a comment - Commit 6ce4bbd2c25310a10b1e46adcbc1c99da1e7878a in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6ce4bbd ] SOLR-9588 : removed guava dependency
      Hide
      shalinmangar Shalin Shekhar Mangar added a comment -

      Closing after 6.3.0 release.

      Show
      shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

        People

        • Assignee:
          noble.paul Noble Paul
          Reporter:
          ichattopadhyaya Ishan Chattopadhyaya
        • Votes:
          0 Vote for this issue
          Watchers:
          7 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development