Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9579

Reuse lucene FieldType in createField flow during ingestion

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 7.0
    • Fix Version/s: 7.0
    • Component/s: Schema and Analysis
    • Labels:
    • Environment:

      This has been primarily tested on Windows 8 and Windows Server 2012 R2

      Description

      During ingestion createField in FieldType is being called for each field on each document. For the subclasses of FieldType without their own implementation of createField the lucene version of FieldType is created to be stored along with the value. However the lucene FieldType object is identical when created from the same SchemaField. In testing ingestion of one million rows with 22 field each we were creating 22 million lucene FieldType objects when only 22 are needed. Solr should lazily initialize a lucene FieldType for each SchemaField and reuse them for future ingestion. Not only does this relieve memory usage but also relieves significant pressure on the gc.

      There are also subclasses of Solr FieldType which create separate Lucene FieldType for stored fields instead of reusing the static in StoredField.

        Attachments

        1. SOLR-9579.patch
          18 kB
          John Call
        2. SOLR-9579.patch
          6 kB
          John Call

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                johncall John Call
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2h
                  2h
                  Remaining:
                  Remaining Estimate - 2h
                  2h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified