Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      sample request
      http://localhost:8983/solr/gettingstarted/config/requestHandler?expandParams=true&componentName=/browse

      The new parameter is expandParams and it expands all the params and will show all the params expanded individually and cumulative

      response:

      {
         "config":{"requestHandler":{"/browse":{
              "name":"/browse",
              "class":"solr.SearchHandler",
              "useParams":"query,facets,velocity,browse",
              "defaults":{"echoParams":"explicit"},
              "_useParamsExpanded_":{
                "query":{
                  "defType":"edismax",
                  "q.alt":"*:*",
                  "rows":"10",
                  "fl":"*,score",
                  "":{"v":0}},
                "facets":{
                  "facet":"on",
                  "facet.mincount":"1",
                  "":{"v":0}},
                "velocity":{
                  "wt":"velocity",
                  "v.template":"browse",
                  "v.layout":"layout",
                  "":{"v":0}},
                "browse":"[NOT AVAILABLE]"},
              "_effectiveParams_":{
                "q.alt":"*:*",
                "indent":"true",
                "echoParams":"explicit",
                "v.layout":"layout",
                "fl":"*,score",
                "rows":"10",
                "v.template":"browse",
                "defType":"edismax",
                "facet.mincount":"1",
                "wt":"json",
                "facet":"on"}}}}}
      
      1. SOLR-9572.patch
        13 kB
        Noble Paul
      2. SOLR-9572.patch
        11 kB
        Noble Paul

        Activity

        Hide
        noble.paul Noble Paul added a comment -

        without testcase

        Show
        noble.paul Noble Paul added a comment - without testcase
        Hide
        noble.paul Noble Paul added a comment -

        tests added

        Show
        noble.paul Noble Paul added a comment - tests added
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 09890f7f93cb85bc2c6b57b9337f8bb95addee60 in lucene-solr's branch refs/heads/master from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=09890f7 ]

        SOLR-9572: config API to show expanded useParams for request handlers inline

        Show
        jira-bot ASF subversion and git services added a comment - Commit 09890f7f93cb85bc2c6b57b9337f8bb95addee60 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=09890f7 ] SOLR-9572 : config API to show expanded useParams for request handlers inline
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b0d0f39b3a11b092ba7b40e974e63199dda636f5 in lucene-solr's branch refs/heads/branch_6x from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b0d0f39 ]

        SOLR-9572: config API to show expanded useParams for request handlers inline

        Show
        jira-bot ASF subversion and git services added a comment - Commit b0d0f39b3a11b092ba7b40e974e63199dda636f5 in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b0d0f39 ] SOLR-9572 : config API to show expanded useParams for request handlers inline
        Hide
        arafalov Alexandre Rafalovitch added a comment -

        The _effectiveParameters_ parameter name is quite misleading, as it still does not seem to incorporate the parameters that are defined in initParams sections (as per SOLR-6960).

        Show
        arafalov Alexandre Rafalovitch added a comment - The _effectiveParameters_ parameter name is quite misleading, as it still does not seem to incorporate the parameters that are defined in initParams sections (as per SOLR-6960 ).
        Hide
        noble.paul Noble Paul added a comment -

        Do you wish to suggest another name!

        BTW, please open a ticket for the init params bug

        Show
        noble.paul Noble Paul added a comment - Do you wish to suggest another name! BTW, please open a ticket for the init params bug
        Hide
        arafalov Alexandre Rafalovitch added a comment -

        SOLR-6960 IS the other ticket.

        I don't actually think we need another name for a partial combined output at all. What users need IMHO is to see those individual definitions but also see the final super-combined version. Otherwise they have to remember/guess the order in which these additional different ways to define parameters apply, which is hard to expect or debug.

        So, I like _effectiveParameters_, but it should actually reflect the final effective parameters, not some intermediate stage.

        Show
        arafalov Alexandre Rafalovitch added a comment - SOLR-6960 IS the other ticket. I don't actually think we need another name for a partial combined output at all. What users need IMHO is to see those individual definitions but also see the final super-combined version. Otherwise they have to remember/guess the order in which these additional different ways to define parameters apply, which is hard to expect or debug. So, I like _effectiveParameters_, but it should actually reflect the final effective parameters, not some intermediate stage.
        Hide
        noble.paul Noble Paul added a comment -

        It's supposed to be the final parameters. If it's not, it is a bug

        Show
        noble.paul Noble Paul added a comment - It's supposed to be the final parameters. If it's not, it is a bug
        Hide
        arafalov Alexandre Rafalovitch added a comment -

        Then it is a bug. Can you reopen this issue or take over the other issue then and fix it within that (feel free to rename). Or do you need me to give you anything else?

        Show
        arafalov Alexandre Rafalovitch added a comment - Then it is a bug. Can you reopen this issue or take over the other issue then and fix it within that (feel free to rename). Or do you need me to give you anything else?
        Hide
        noble.paul Noble Paul added a comment -

        We can't reopen tickets closed in a public release. We should open another

        Show
        noble.paul Noble Paul added a comment - We can't reopen tickets closed in a public release. We should open another
        Hide
        arafalov Alexandre Rafalovitch added a comment -

        Why open another, when SOLR-6960 is already open specifically for that information missing? Just use that one.

        Show
        arafalov Alexandre Rafalovitch added a comment - Why open another, when SOLR-6960 is already open specifically for that information missing? Just use that one.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            noble.paul Noble Paul
            Reporter:
            noble.paul Noble Paul
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development