Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9544

ObjectReleaseTracker can false-fail on late asynchronous closing resources

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      SolrTestCaseJ4 assumes that, once its embedded CoreContainer has shutdown, it can check the ObjectReleaseTracker and ensure that all cores are closed. However, if the test has kicked off some asynchronous core reloads then this assumption doesn't necessarily hold, particularly on slow machines.

      See http://jenkins.thetaphi.de/job/Lucene-Solr-6.x-Windows/466/ for an example failure.

      1. SOLR-9544.patch
        5 kB
        Alan Woodward

        Activity

        Hide
        romseygeek Alan Woodward added a comment -

        I guess the simplest way to fix this is to add some retry-and-timeout logic to ObjectReleaseTracker.clearObjectTrackerAndCheckEmpty()?

        Show
        romseygeek Alan Woodward added a comment - I guess the simplest way to fix this is to add some retry-and-timeout logic to ObjectReleaseTracker.clearObjectTrackerAndCheckEmpty()?
        Hide
        romseygeek Alan Woodward added a comment -

        Patch, adding a waitSeconds parameter to ORT.clearObjectTrackerAndCheckEmpty().

        Show
        romseygeek Alan Woodward added a comment - Patch, adding a waitSeconds parameter to ORT.clearObjectTrackerAndCheckEmpty().
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 36b39a2c415d812d143ebcbc88d90ecd15754cbb in lucene-solr's branch refs/heads/branch_6x from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=36b39a2 ]

        SOLR-9544: Give ObjectReleaseTracker more time for async closing objects

        Show
        jira-bot ASF subversion and git services added a comment - Commit 36b39a2c415d812d143ebcbc88d90ecd15754cbb in lucene-solr's branch refs/heads/branch_6x from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=36b39a2 ] SOLR-9544 : Give ObjectReleaseTracker more time for async closing objects
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c55a14e198072c16a834d5b3683c5edaa0c67e5d in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c55a14e ]

        SOLR-9544: Give ObjectReleaseTracker more time for async closing objects

        Show
        jira-bot ASF subversion and git services added a comment - Commit c55a14e198072c16a834d5b3683c5edaa0c67e5d in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c55a14e ] SOLR-9544 : Give ObjectReleaseTracker more time for async closing objects
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            romseygeek Alan Woodward
            Reporter:
            romseygeek Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development