Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9538

Relocate {JSON,Smile}WriterTest and TestBinaryResponseWriter to org.apache.solr.response

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, master (7.0)
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      JSONWriterTest, SmileWriterTest and TestBinaryResponseWriter are currently in the org.apache.solr.request package but the classes they test (JSONResponseWriter, SmileWriter, BinaryResponseWriter) are in the org.apache.solr.response package.

      This patch moves the tests to the response package.

        Issue Links

          Activity

          Hide
          jm100 Jonny Marks added a comment -

          Attaching patch

          Show
          jm100 Jonny Marks added a comment - Attaching patch
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 93bc88d966b3758dda61c54b0dce2c8b78f2f2d6 in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=93bc88d ]

          SOLR-9538: Relocate (BinaryResponse|JSON|Smile)Writer tests to org.apache.solr.response which is the package of the classes they test. (Jonny Marks via Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 93bc88d966b3758dda61c54b0dce2c8b78f2f2d6 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=93bc88d ] SOLR-9538 : Relocate (BinaryResponse|JSON|Smile)Writer tests to org.apache.solr.response which is the package of the classes they test. (Jonny Marks via Christine Poerschke)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7d05a081a97d849f0bfb1f510e97927f7d8a7954 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7d05a08 ]

          SOLR-9538: Relocate (BinaryResponse|JSON|Smile)Writer tests to org.apache.solr.response which is the package of the classes they test. (Jonny Marks via Christine Poerschke)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7d05a081a97d849f0bfb1f510e97927f7d8a7954 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7d05a08 ] SOLR-9538 : Relocate (BinaryResponse|JSON|Smile)Writer tests to org.apache.solr.response which is the package of the classes they test. (Jonny Marks via Christine Poerschke)
          Hide
          cpoerschke Christine Poerschke added a comment -

          Thanks Jonny!

          Show
          cpoerschke Christine Poerschke added a comment - Thanks Jonny!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7a6567e4a66451a2b4b7cba5e6b8373ad200ea8e in lucene-solr's branch refs/heads/master from Christine Poerschke
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7a6567e ]

          TestSmileRequest to import response.SmileWriterTest instead of (deprecated) request.SmileWriterTest predecessor. Then remove (three) deprecated/relocated tests. (Follow-ons from SOLR-9538 itself.)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7a6567e4a66451a2b4b7cba5e6b8373ad200ea8e in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7a6567e ] TestSmileRequest to import response.SmileWriterTest instead of (deprecated) request.SmileWriterTest predecessor. Then remove (three) deprecated/relocated tests. (Follow-ons from SOLR-9538 itself.)

            People

            • Assignee:
              cpoerschke Christine Poerschke
              Reporter:
              jm100 Jonny Marks
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development