[SOLR-9519] Check sub-facets of empty facet buckets for operations that may expand the domain (like filter exclusions)

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.4, 7.0
• Component/s: Facet Module
• Assignee: Unassigned
• Reporter: Yonik Seeley
• Created: 15/Sep/16 13:25
• Updated: 08/Jun/19 15:33
• Resolved: 08/Nov/16 18:19

Description

http://markmail.org/message/bgplt2qdxc7gqga5

Background: the JSON Facet API does not execute sub-facets for a facet
bucket with a 0 count (and the root facet bucket is like any other
facet bucket).
This was to help prevent the combinatorial explosion of deeply nested
sub-facets with useless information.

This is obviously incorrect though, when a sub-facet does something
that can expand the domain rather than just restrict it. Facet
exclusions are one of these cases.
For zero facet buckets, we should check if any sub-facets have these
properties and then recurse if so.

Aside: not processing empty sets also helped with issues like what junk values to fill in for statistics... min, max, average, std, etc. JSON doesn't even officially support NaN, so it's nice to be able to leave these junk values out in many circumstances.