Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9519

Check sub-facets of empty facet buckets for operations that may expand the domain (like filter exclusions)

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: Facet Module
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      http://markmail.org/message/bgplt2qdxc7gqga5

      Background: the JSON Facet API does not execute sub-facets for a facet
      bucket with a 0 count (and the root facet bucket is like any other
      facet bucket).
      This was to help prevent the combinatorial explosion of deeply nested
      sub-facets with useless information.

      This is obviously incorrect though, when a sub-facet does something
      that can expand the domain rather than just restrict it. Facet
      exclusions are one of these cases.
      For zero facet buckets, we should check if any sub-facets have these
      properties and then recurse if so.

      Aside: not processing empty sets also helped with issues like what junk values to fill in for statistics... min, max, average, std, etc. JSON doesn't even officially support NaN, so it's nice to be able to leave these junk values out in many circumstances.

        Attachments

        1. SOLR-9519.patch
          1 kB
          Michael Sun
        2. SOLR-9519.patch
          2 kB
          Michael Sun
        3. SOLR-9519.patch
          2 kB
          Michael Sun
        4. SOLR-9519.patch
          6 kB
          Yonik Seeley
        5. SOLR-9519.patch
          6 kB
          Yonik Seeley

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              yseeley@gmail.com Yonik Seeley
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: