Solr
  1. Solr
  2. SOLR-950

Solr can throw an exception on distributed search due to bad if statement in FacetComponent.java:99

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.4
    • Component/s: search
    • Labels:
      None

      Description

      When issuing a distributed request, the aggregator node caused an exception due to the following code at line 99 in FacetComponent.java

       if (refList == null | refList.size()==0) continue;
      

      note the single pipe for a bitwise OR rather than boolean OR

      Change code to:

      if (refList == null || refList.size() == 0) continue;
      

        Activity

        Grant Ingersoll made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Shalin Shekhar Mangar added a comment -

        You are right Yonik. This was introduced after 1.3 was released. I'll update the changelog.

        Show
        Shalin Shekhar Mangar added a comment - You are right Yonik. This was introduced after 1.3 was released. I'll update the changelog.
        Hide
        Yonik Seeley added a comment -

        I believe this bug was in unreleased code only (probably introduced through my changes to support multi-select faceting)?
        That should somehow be made clear in CHANGES.txt so people don't think this was a 1.3 bug.

        Show
        Yonik Seeley added a comment - I believe this bug was in unreleased code only (probably introduced through my changes to support multi-select faceting)? That should somehow be made clear in CHANGES.txt so people don't think this was a 1.3 bug.
        Hide
        Jayson Minard added a comment -

        Shalin, thanks for committing the fix.

        Show
        Jayson Minard added a comment - Shalin, thanks for committing the fix.
        Shalin Shekhar Mangar made changes -
        Affects Version/s 1.3 [ 12312486 ]
        Affects Version/s 1.3.1 [ 12313422 ]
        Shalin Shekhar Mangar made changes -
        Fix Version/s 1.4 [ 12313351 ]
        Assignee Shalin Shekhar Mangar [ shalinmangar ]
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed revision 733005.

        Thanks Jayson!

        Show
        Shalin Shekhar Mangar added a comment - Committed revision 733005. Thanks Jayson!
        Jayson Minard made changes -
        Field Original Value New Value
        Affects Version/s 1.3.1 [ 12313422 ]
        Affects Version/s 1.4 [ 12313351 ]
        Jayson Minard created issue -

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Jayson Minard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development