Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9484

The modify collection API should wait for the modified properties to show up in the cluster state

    Details

      Description

      The modify collection API doesn't wait for the updated properties to show up in the cluster state. Say you increase the maxShardsPerNode for a collection using this API, if you try to add a replica immediately after modify collection API returns then the overseer sometimes doesn't see the updated property and refuses to add a new replica.

      1. SOLR-9484.patch
        4 kB
        Cao Manh Dat
      2. SOLR-9484.patch
        4 kB
        Cao Manh Dat

        Activity

        Hide
        caomanhdat Cao Manh Dat added a comment -

        Initial patch for this issue.

        Show
        caomanhdat Cao Manh Dat added a comment - Initial patch for this issue.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Thanks Dat. A few comments:

        1. The Thread.sleep should move to end of the loop instead of the start. This is so that the first iteration doesn't sleep unnecessarily.
        2. The DocCollection variable is named "clusterProps". Cluster props indicate that this is a cluster property but it is not. It should be called collection instead.
        3. The "isEquals" doesn't indicate its purpose very well. Perhaps better to rename it as "isCollectionModified" or maybe "areChangesVisible"?
        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Thanks Dat. A few comments: The Thread.sleep should move to end of the loop instead of the start. This is so that the first iteration doesn't sleep unnecessarily. The DocCollection variable is named "clusterProps". Cluster props indicate that this is a cluster property but it is not. It should be called collection instead. The "isEquals" doesn't indicate its purpose very well. Perhaps better to rename it as "isCollectionModified" or maybe "areChangesVisible"?
        Hide
        caomanhdat Cao Manh Dat added a comment -

        Thanks Shalin,
        Those are good modification, this is the updated patch.

        Show
        caomanhdat Cao Manh Dat added a comment - Thanks Shalin, Those are good modification, this is the updated patch.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 70fd627ca78ed58d0316e6c173a398efc69aaa5e in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=70fd627 ]

        SOLR-9484: The modify collection API should wait for the modified properties to show up in the cluster state

        Show
        jira-bot ASF subversion and git services added a comment - Commit 70fd627ca78ed58d0316e6c173a398efc69aaa5e in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=70fd627 ] SOLR-9484 : The modify collection API should wait for the modified properties to show up in the cluster state
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 34b1f65c4d0d884528620c96430096539e9fb743 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=34b1f65 ]

        SOLR-9484: The modify collection API should wait for the modified properties to show up in the cluster state

        (cherry picked from commit 70fd627)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 34b1f65c4d0d884528620c96430096539e9fb743 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=34b1f65 ] SOLR-9484 : The modify collection API should wait for the modified properties to show up in the cluster state (cherry picked from commit 70fd627)
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Thanks Dat!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Thanks Dat!
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            caomanhdat Cao Manh Dat
            Reporter:
            shalinmangar Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development